fix(a11y): make click-only controls keyboard operable - #741
Draft
beruro wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Seven visible frontend controls were mouse-only: non-semantic click targets had no focus stop, keyboard activation, or exposed state. Keyboard and assistive-technology users could not operate collapsed diff rows, JSON nodes, the replace disclosure, the date trigger, simulator rows, or the primary BrowseCard action.
Solution
createKeyboardActivationHandler; no new behavior abstraction was introduced.The frontend UI audit is recorded in
docs/frontend-ui-audit-2026-08-07/KeyboardOperability.md: 7 accessibility fixes, 7 raw-element decisions kept with documented design-system reasons, and 0 abstraction candidates.Potential risks
divto nativebutton; repository CSS resets cover native defaults, but untracked downstream structure selectors could differ.getCurrentWindow()without Tauri window metadata, so this PR remains Draft until desktop visual QA/screenshots cover the affected states.Verification
./node_modules/.bin/vitest run src/util/dom/__tests__/keyboardActivation.test.ts src/engines/ChatPanel/components/DebugJsonViewer/DebugJsonViewer.test.ts— PASS, 2 files / 7 tests.git diff --name-only origin/develop...HEAD -- '*.ts' '*.tsx' | xargs ./node_modules/.bin/eslint— PASS, no errors or warnings../node_modules/.bin/tsc --noEmit --pretty false— PASS.git diff --check origin/develop— PASS.npm run dev:frontend:lightand browser navigation to the local app — frontend compiled, but desktop visual QA was NOT COMPLETED because the non-Tauri browser host fails at Tauri window metadata initialization.origin/develop— PASS, no conflicts; automated checks were run after integration.