refactor(orgtrack): remove unused imported history modules - #771
Closed
beruro wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by #780, which preserves this change as an independent commit and has passed the consolidated CI suite. The source branch is retained for recovery. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three tracked files under
sources/imported_historyduplicate 600 lines of the live implementation inmod.rs, but the parent module never declares or imports them. Because Rust never compiles these files, they form a second, misleading copy of core imported-history behavior and can silently drift from the production path.Solution
Remove the unreferenced
chunks.rs,impact.rs, androws.rsfiles. The authoritative implementation remains insources/imported_history/mod.rs, which is the path used by all production callers and the existing imported-history tests.Potential risks
Runtime risk is low because the deleted files were not part of the Rust module graph and had no production callers. The main risk would be an undocumented external build step reading source files by path; repository-wide reference and module-declaration sweeps found no such path. Rollback is a normal revert of this commit.
Verification
cargo check -p orgtrack_core— passed before and after the deletion.cargo test -p orgtrack_core imported_history— 72 passed, 2 ignored, 0 failed.git diff --check— passed.cargo clippy -p orgtrack_core --all-targets -- -D warnings— attempted; blocked by a pre-existingcollapsible_else_ifwarning in unchangedsources/imported_history/window.rs:189ondevelop.mod chunks,mod impact, ormod rowsdeclarations for the deleted files and no production imports of those modules.UI evidence is not applicable because this removes Rust source files that were never compiled or rendered.