test: run the feature scenarios on ubuntu 26.04 - #12
Merged
Conversation
The devcontainer this repo feeds moved to ubuntu 26.04 in orianna-ai/devcontainer, so the scenarios were proving these features work on a base nothing actually uses any more. The tag is "ubuntu26.04", not "ubuntu-26.04" — mcr dropped the hyphen at 26.04, and the hyphenated form 404s. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MB7zNmdzPYMpwkUWxAjSFt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Softlight Overview
UX Score: 5/5
Softlight reviewed this change and found no issues.
To run Softlight again, click here or comment @softlight.
Moves every feature scenario off
base:ubuntu-22.04and ontobase:ubuntu26.04.Follow-up to #11. The devcontainer these features feed moved to ubuntu 26.04 in orianna-ai/devcontainer#79, so the scenarios were proving the features work on a base nothing actually uses any more.
Changes
test/buildbuddy/scenarios.jsontest/cloud-sql-proxy/scenarios.jsontest/playwright/scenarios.jsonNotes
The tag is
ubuntu26.04, notubuntu-26.04— mcr dropped the hyphen at 26.04, and the hyphenated form 404s. It is the same tag orianna-ai/devcontainer already builds from.The playwright scenario is the one to watch. Playwright's
install-depsmaps/etc/os-releaseagainst a list of known distributions, and 26.04 may not be in the version of Playwright thatlatestresolves to yet. If that is the case this PR will surface it as a reddevcontainer-featuresjob rather than a silent gap.Testing
pre-commit run --all-filespasses. The scenarios need Docker, so they run in CI.Generated by Claude Code
Note
Low Risk
Test-only scenario image tag changes with no production runtime impact; possible CI failure if Playwright deps do not support 26.04 yet.
Overview
Aligns devcontainer feature scenario tests with the production devcontainer base by switching
mcr.microsoft.com/devcontainers/basefromubuntu-22.04toubuntu26.04in all three scenario configs (buildbuddy,cloud-sql-proxy,playwright).Feature sets and users are unchanged; only the CI base image tag updates to match what downstream devcontainers actually use (including the
ubuntu26.04naming without a hyphen).The playwright scenario is the main regression signal: Playwright
install-depsmay not yet recognize Ubuntu 26.04 whenversion: latestis resolved, which would fail thedevcontainer-featuresjob rather than leaving a silent mismatch.Reviewed by Cursor Bugbot for commit ae8ece7. Configure here.
Greptile Summary
The PR moves all feature scenarios from the Ubuntu 22.04 devcontainer base image to Ubuntu 26.04 so CI exercises the distribution used downstream.
Confidence Score: 5/5
The PR appears safe to merge, with the changed scenarios appropriately exercising the intended Ubuntu 26.04 base image.
The changes consistently update only scenario image references, and no concrete changed-code failure remains beyond compatibility outcomes that these scenarios are intentionally designed to detect.
Important Files Changed
Reviews (1): Last reviewed commit: "test: run the feature scenarios on ubunt..." | Re-trigger Greptile