Major refactor: Convert to functional API and improve architecture#12
Merged
Major refactor: Convert to functional API and improve architecture#12
Conversation
## Breaking Changes
- Remove GenServer-based API in favor of functional approach
- Replace Collection/Disbursement modules with Collections/Disbursements
- Change from stateful to stateless API calls
## New Features
- Add MomoapiElixir.Config module for environment variable support
- Add production configuration with proper base URLs
- Add comprehensive input validation with structured error responses
- Add environment-specific configuration (dev/test/prod)
## Improvements
- Replace deprecated Mix.Config with modern Config module
- Add proper typespecs and documentation throughout
- Implement configurable HTTP client for better testability
- Add comprehensive error handling with {:ok, result} / {:error, reason} patterns
- Remove code duplication between collections and disbursements
- Add support for environment variables (MOMO_SUBSCRIPTION_KEY, etc.)
## Technical Changes
- Convert from GenServer to pure functional modules
- Add proper behaviour-based dependency injection
- Implement compile-time HTTP client configuration
- Add structured validation errors with field-level details
- Update all tests to work with new functional API
- Add validator tests with comprehensive coverage
## Configuration
- Add config/prod.exs for production environment
- Update base URLs: sandbox vs production endpoints
- Add environment variable support for secure credential management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a major refactoring of the MTN MoMo Elixir library to modernize its architecture and follow Elixir best practices.
Fixes #11
Changes Made
🔥 Breaking Changes
✨ New Features
MomoapiElixir.Configmodule🚀 Improvements
Mix.ConfigwithConfig{:ok, result}/{:error, reason}patterns throughoutAPI Changes
Before (GenServer)
After (Functional)
Environment Variables (New!)
Technical Improvements
https://momoapi.mtn.comTesting
Configuration Files Added/Updated
config/prod.exs- NEW: Production configurationconfig/config.exs- Updated to use modern Configconfig/dev.exs- Added base_url configurationconfig/test.exs- Updated with proper test settingsMigration Guide
For existing users, update your code:
Impact
This refactor makes the library:
Test Plan
Ready for review! 🚀