Skip to content

fix: quote paths in buildV2VCommand to handle spaces in VM names #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miguelntt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: quote paths in buildV2VCommand to handle spaces in VM names #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions plugins/module_utils/nbdkit/nbdkit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,18 +405,19 @@ func versionIsLower(cVersion, rVersion string) bool {
*/

// buildV2VCommand constructs the virt-v2v-in-place command string.
// Paths are wrapped in single quotes to handle directory names with spaces.
func buildV2VCommand(path, rsPath, bsPath, extraOpts string) string {
opts := ""
if rsPath != "" {
opts = opts + " --run " + rsPath
opts = opts + " --run '" + rsPath + "'"
}
if bsPath != "" {
opts = opts + " --firstboot " + bsPath
opts = opts + " --firstboot '" + bsPath + "'"
}
if extraOpts != "" {
opts += " " + extraOpts
}
return "virt-v2v-in-place" + opts + " -i disk " + path
return "virt-v2v-in-place" + opts + " -i disk '" + path + "'"
}

func V2VConversion(path, rsPath, bsPath, extraOpts string, debug bool) error {
Expand Down
Loading