Skip to content

Enable GitHub Pages for the osac-workspace repository#90

Merged
jhernand merged 1 commit into
osac-project:mainfrom
oourfali:feat/enable-pages-osac-workspace
Jun 4, 2026
Merged

Enable GitHub Pages for the osac-workspace repository#90
jhernand merged 1 commit into
osac-project:mainfrom
oourfali:feat/enable-pages-osac-workspace

Conversation

@oourfali
Copy link
Copy Markdown
Contributor

@oourfali oourfali commented Jun 4, 2026

Summary

Test plan

  • Verify that terraform plan shows no unexpected changes beyond enabling Pages
  • After apply, confirm GitHub Pages remains enabled on the osac-workspace repository with build_type = "workflow"
  • Confirm the PR dashboard is accessible at https://osac-project.github.io/osac-workspace/pr-dashboard/

Related: #89

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Configured GitHub Pages with workflow-based build settings for the workspace repository.

The osac-workspace repository has a GitHub Actions workflow that publishes
a PR dashboard to GitHub Pages. However, Pages was only enabled manually
in the repository settings, so it gets disabled every time Terraform is
re-applied. This adds the pages configuration with build_type = "workflow"
to persist the setting through Terraform applies.

Assisted-by: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Oved Ourfali <oourfali@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 28855e94-f136-43f3-b244-7713fa6a2526

📥 Commits

Reviewing files that changed from the base of the PR and between b328c36 and 33ba1e8.

📒 Files selected for processing (1)
  • repositories.tf

Walkthrough

The repo_osac_workspace Terraform module now explicitly configures GitHub Pages to use workflow-based builds by adding a pages block with build_type = "workflow".

Changes

GitHub Pages workflow configuration

Layer / File(s) Summary
GitHub Pages workflow build type
repositories.tf
The repo_osac_workspace module adds a pages configuration block that sets build_type to "workflow", enabling GitHub Actions workflows to handle Pages building and deployment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Security Review

Risk Severity: LOW

This configuration change enables GitHub Pages workflow-based builds for the OSAC workspace repository. Security implications are minimal at the infrastructure level:

  • The change itself introduces no credential exposure or permission escalation
  • The actual risk posture depends entirely on the security of the workflows that execute the build—ensure the referenced workflow files do not contain secrets in plaintext, validate workflow inputs, and review any external actions used
  • Workflow-based builds are preferable to legacy builder because they provide explicit control and auditability through version-controlled workflow files

Possibly related PRs

  • osac-project/github-config#89: Adds the same pages configuration with build_type = "workflow" pattern to a different repository module in the same Terraform configuration.

Suggested reviewers

  • larsks

Poem

📄 A tiny change, so light and lean,
Pages configured, workflow-clean,
Three lines added, crystal clear—
GitHub's build pipeline, drawing near! 🚀

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ai-Attribution ⚠️ Warning Commit uses Co-Authored-By trailer for AI tool (Claude), which violates Red Hat attribution standards; should use Assisted-by or Generated-by instead. Replace Co-Authored-By trailer with proper Assisted-by/Generated-by trailers per Red Hat standards for AI-assisted commits.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding GitHub Pages configuration to the osac-workspace repository via Terraform.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed No hardcoded secrets found in repositories.tf or PR. GitHub App client ID (Iv23...) is not a secret per official GitHub documentation; sensitive credentials correctly use secrets mechanism.
No-Weak-Crypto ✅ Passed No weak cryptographic implementations detected. The PR only modifies Terraform configuration for GitHub Pages settings; no crypto code is present or used.
No-Injection-Vectors ✅ Passed PR only modifies Terraform HCL configuration with hardcoded values; no injection vectors or code execution patterns detected.
Container-Privileges ✅ Passed PR only modifies Terraform GitHub repository configuration; no container or Kubernetes manifests present, so container-privileges check is not applicable.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only a pages = { build_type = "workflow" } configuration to repositories.tf with no logging statements, outputs, or sensitive data exposure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jhernand jhernand merged commit d8c2848 into osac-project:main Jun 4, 2026
2 checks passed
Comment thread repositories.tf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants