Enhances documentation deploying OSAC UI on an OpenShift cluster#23
Enhances documentation deploying OSAC UI on an OpenShift cluster#23alosadagrande wants to merge 2 commits into
Conversation
Signed-off-by: Alberto Losada <alosadag@redhat.com>
WalkthroughThis PR consolidates OpenShift deployment documentation by introducing a comprehensive deployment guide and updating existing entry points. The new guide walks operators through container image build, Keycloak OIDC configuration, fulfillment service integration, UI deployment, verification, and troubleshooting. README.md and Helm chart documentation are updated to reference the guide, and runbook instructions now include explicit manifest application commands. ChangesOpenShift Deployment Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Risk Assessment: Low – Documentation-only changes with no code modifications, dependency alterations, or exported entity changes. Content accuracy and completeness are primary concerns. Review focus: verify deployment steps align with actual service APIs, configuration expectations (Keycloak client IDs, environment variable names), and security posture (TLS, token issuer trust chain, external hostname configuration). Suggested reviewers
Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/deployment-openshift-guide.md`:
- Around line 101-103: Add a language hint to the fenced code block containing
the CLI flag (--grpc-authn-trusted-token-issuers=...) so the fence is labeled as
bash; locate the fenced block around that flag in
docs/deployment-openshift-guide.md and change the opening triple backticks to
include "bash" (e.g., ```bash) to satisfy markdownlint and improve copy/paste.
- Around line 56-60: The grep command in the docs is invalid because `-A`
requires a numeric count; update the snippet that searches for the
KEYCLOAK_ADMIN and KEYCLOAK_ADMIN_PASSWORD environment vars to include a numeric
context value (e.g., change the pipeline to use `grep -E " KEYCLOAK_ADMIN|
KEYCLOAK_ADMIN_PASSWORD" -A 1`) so the command returns the matching lines plus
the following line containing the value instead of failing.
- Around line 156-158: Update the docs to stop steering operators toward setting
FULFILLMENT_TLS_INSECURE=1 and OIDC_TLS_INSECURE=1 as a normal remedy; instead
reference the repository's CA-bundle trust handling and instruct operators to
add the service/Keycloak CA to the cluster CA bundle or the container's trust
store (and only use *_TLS_INSECURE=1 for short-lived local testing with an
explicit warning), and revise the FULFILLMENT_API_URL note to reiterate using
the internal Service URL while warning that disabling TLS verification is
unacceptable for production.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: aa540c39-d01f-41b1-8727-8eae98b4c2ff
📒 Files selected for processing (4)
README.mddeploy/chart/README.mddocs/deployment-openshift-guide.mddocs/runbook.md
Signed-off-by: Alberto Losada <alosadag@redhat.com>
Adds docs/deployment-openshift-guide.md, a full walkthrough for deploying OSAC UI on OpenShift with fulfillment-service and Keycloak.
Updates existing docs to reference the guide and align OpenShift deployment instructions with the current setup.
Summary by CodeRabbit