Skip to content

Revert "Set release log level to info at compile time"#110

Merged
oschwald merged 1 commit intooschwald:mainfrom
monosans:patch-1
Feb 16, 2026
Merged

Revert "Set release log level to info at compile time"#110
oschwald merged 1 commit intooschwald:mainfrom
monosans:patch-1

Conversation

@monosans
Copy link
Contributor

@monosans monosans commented Feb 16, 2026

Fixes #109

This reverts commit e525987.

Summary by CodeRabbit

  • Chores
    • Updated logging dependency configuration to use default feature settings.

@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Removed the release_max_level_info feature from the log dependency specification in Cargo.toml, changing it from a detailed feature declaration to a simple version constraint. This prevents feature flag conflicts in library dependencies.

Changes

Cohort / File(s) Summary
Dependency Configuration
Cargo.toml
Removed release_max_level_info feature from log dependency to comply with library best practices; global features should only be specified in applications, not libraries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hoppy fix, so clean and neat,
The feature flag now obsolete,
Libraries shouldn't shout so loud,
Let apps decide—make no one proud! 🐰✨

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting a previous commit that set the release log level to info at compile time.
Linked Issues check ✅ Passed The PR directly addresses issue #109 by removing the release_max_level_info feature from the log dependency, which was preventing libraries from setting global compile-time log levels.
Out of Scope Changes check ✅ Passed The change is limited to reverting the log dependency specification in Cargo.toml, which is directly related to fixing issue #109 with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oschwald oschwald merged commit 0b19ee2 into oschwald:main Feb 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

log feature release_max_level_info should not be specified in libraries

2 participants