Add timestamp(tz) column types - #2471
Merged
Merged
Conversation
lonvia
reviewed
May 17, 2026
lonvia
left a comment
lonvia
left a comment
Collaborator
There was a problem hiding this comment.
The tests don't cover timestamp-as-string, don't they?
Collaborator
Author
|
The tests in tests/bdd/flex/timestamp.feature take timestamps from tags and write them as string. |
With the special behaviour that a number is interpreted as seconds since the epoch which is the format used by object.timestamp. This avoids having to format the timestamp as string in the Lua script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the special behaviour that a number is interpreted as seconds since the epoch which is the format used by object.timestamp. This avoids having to format the timestamp as string in the Lua script.