Update UI my places favorite i os#5469
Open
Vladyslav-lys wants to merge 54 commits into
Open
Conversation
… update_ui_my_places_favorite_iOS
… update_ui_my_places_favorite_iOS
… update_ui_my_places_favorite_iOS
…i_my_places_favorite_iOS
… update_ui_my_places_favorite_iOS
128 tasks
tigrim
reviewed
Jun 16, 2026
| import UniformTypeIdentifiers | ||
|
|
||
| extension FavoriteListViewController { | ||
| func areAllSelectableItemsSelected() -> Bool { |
Contributor
There was a problem hiding this comment.
Consider whether SelectionManager can be used here
| self.groupController = groupController | ||
| favoriteItemsToMove = favoriteItems | ||
| groupController.delegate = self | ||
| let modalNavigationController = UINavigationController(rootViewController: groupController) |
| addToTrackGroupName = groupName | ||
| addToTrackFavoriteItems = nil | ||
| viewController.delegate = self | ||
| let modalNavigationController = UINavigationController(rootViewController: viewController) |
| addToTrackGroupName = nil | ||
| viewController.delegate = self | ||
| let modalNavigationController = UINavigationController(rootViewController: viewController) | ||
| navigationController.present(modalNavigationController, animated: true) |
| return UIMenu(title: "", children: [addFolderSection, importSection]) | ||
| } | ||
|
|
||
| func setEdit(_ isEdit: Bool) { |
| format.scale = image.scale | ||
| format.opaque = false | ||
| let renderer = UIGraphicsImageRenderer(size: image.size, format: format) | ||
| return renderer.image { context in |
Contributor
There was a problem hiding this comment.
1)Are we sure the rotated image won't be clipped? The renderer size remains unchanged after rotation.
2) Move to extension
| } | ||
|
|
||
| var snapshot = Snapshot() | ||
| if allFolders.isEmpty { |
Contributor
There was a problem hiding this comment.
if allFolders.isEmpty {
applyEmptyStateSnapshot(animatingDifferences: animatingDifferences)
return
}
| // | ||
|
|
||
| import CoreLocation | ||
| import UniformTypeIdentifiers |
| } | ||
|
|
||
| struct FavoriteFolderRow: Hashable, FavoriteSortableFolder { | ||
| static let subtitleDateFormatter: DateFormatter = { |
| struct FavoriteFolderRow: Hashable, FavoriteSortableFolder { | ||
| static let subtitleDateFormatter: DateFormatter = { | ||
| let formatter = DateFormatter() | ||
| formatter.dateFormat = "d MMM" |
Contributor
There was a problem hiding this comment.
Consider using setLocalizedDateFormatFromTemplate("dMMM") instead of a hardcoded date format to better support different locales
tigrim
reviewed
Jun 18, 2026
tigrim
left a comment
tigrim
left a comment
Contributor
There was a problem hiding this comment.
Folder actions omit nested favorites
- FavoriteListViewController+ContextMenu.swift:52-67, OAFavoritesBridgeHelper.mm:599, 662, 714, 798
If a folder has direct points, “Add to markers/track/navigation” processes only those points and silently ignores its subfolders. Bulk actions have the same problem.
Resolve folder bridge items recursively inside the helper and deduplicate points there.
Distance updates rebuild expensive snapshots every 300 ms
- FavoriteListViewController.swift:161-189, OAFavoritesBridgeHelper.mm:44-58
Each heading/location update recreates bridge objects, icons, filesystem attributes, subtree counts, and performs repeated nested scans. Large favorite collections will cause UI stalls and battery usage.
Cache structural metadata and update only visible point distance/direction cells.
Current folder becomes stale after being renamed
- FavoriteListViewController+Delegates.swift:196-203, FavoriteListViewController+DataSource.swift:225
ScreenMode.folder retains the old bridge item/group name. Renaming from the appearance editor then reloads the deleted path, producing an empty screen and stale title.
Store a mutable group identifier or replace/pop the controller after rename.
Import notification may mutate UIKit off-main
- FavoriteListViewController+Actions.swift:232
favoriteDataDidChange() calls diffable data-source APIs without enforcing the main thread.
Dispatch to the main queue, as already done in productPurchased()
| return YES; | ||
| } | ||
|
|
||
| + (void)renameFavoriteGroup:(NSString *)groupName newName:(NSString *)newName |
Contributor
There was a problem hiding this comment.
Rename/move can silently merge folders and corrupt
- hierarchyFavoriteListViewController+Actions.swift:93, OAFavoritesBridgeHelper.mm:192, 983, OAFavoritesHelper.mm:540
- Duplicate destination names are not rejected. updateGroup silently merges points into an existing group. Names containing / can also restructure the hierarchy unexpectedly.
- Validate every destination path before mutation, reject /, and require explicit confirmation for merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.