Skip to content

Active record adapter enums and multiple joins per table#1626

Draft
lp wants to merge 7 commits intoosohq:mainfrom
lp:active-record-adapter-enums-and-multiple-joins-per-table
Draft

Active record adapter enums and multiple joins per table#1626
lp wants to merge 7 commits intoosohq:mainfrom
lp:active-record-adapter-enums-and-multiple-joins-per-table

Conversation

@lp
Copy link
Copy Markdown
Contributor

@lp lp commented Sep 19, 2022

Why

  • ActiveRecord supports enum methods which needs some translation in the ActiveRecordAdapter
  • Some table-relations requires the same table to be joined multiple-times, like when different ActiveRecord models share the same table

Todo

  • no tests yet to support 👆

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 19, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@gj
Copy link
Copy Markdown
Member

gj commented Oct 12, 2022

@lp gonna mark this one as a draft since it looks like it's still blocked on test coverage (based on the PR description)

@gj gj marked this pull request as draft October 12, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants