atomic peer.peerInfo by using atomic.Pointer[table.PeerInfo]#3306
Closed
nplanelcisco wants to merge 1 commit intoosrg:masterfrom
Closed
atomic peer.peerInfo by using atomic.Pointer[table.PeerInfo]#3306nplanelcisco wants to merge 1 commit intoosrg:masterfrom
nplanelcisco wants to merge 1 commit intoosrg:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the peer.peerInfo field to be concurrency-safe by switching it to atomic.Pointer[table.PeerInfo], and updates call sites (including tests) to use Load()/Store() accordingly.
Changes:
- Change
peer.peerInfofrom*table.PeerInfotoatomic.Pointer[table.PeerInfo]. - Update server runtime code to use
peer.peerInfo.Load()/peer.peerInfo.Store(...). - Update unit tests to use
Load()/Store()when constructing paths and peers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/server/peer.go | Changes peer.peerInfo to atomic.Pointer and updates message processing to pass peer.peerInfo.Load() into table APIs. |
| pkg/server/server.go | Replaces direct pointer usage with atomic Load()/Store() for policy options, path attribute updates, and watcher events. |
| pkg/server/server_test.go | Updates test helpers and path construction to use peer.peerInfo.Store(...) and peer.peerInfo.Load(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Pushed, thanks! Sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.