Fix backend lint errors in PostgresConnector and statistics endpoint#293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
C0321(multiple-statements),E0203(access-member-before-definition), andE1120(missing parameter) reported for backend modules.Description
PostgresConnector.connectiontoNonein__init__and simplify theconnect()guard to avoid accessing the member before definition and ensure a clear connection check.Backend/postgres_connector.py(rollback handling, polynomial monomial construction, and string concatenation branches) into multi-line blocks to satisfyC0321style rules./get_statisticsroute inBackend/server.pyto callconnector.build_where_text(filters)and pass bothwhere_sqlandparamsintoconnector.get_statistics()to supply the required arguments.Testing
python -m py_compile Backend/postgres_connector.py Backend/server.py.pylint Backend/postgres_connector.py Backend/server.pybutpylintis not available in the execution environment, so lint checks could not be re-run here.Codex Task