Adds archive type detection and zip support to ExtractArchiveFile().#1108
Open
Adds archive type detection and zip support to ExtractArchiveFile().#1108
Conversation
tiegz
commented
Mar 12, 2025
| if outputDir == "" { | ||
| return fmt.Errorf("outputDir is empty") | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
moved this out of extractTar() so it runs earlier
Signed-off-by: Tieg Zaharia <tieg.zaharia@gmail.com>
95eed6b to
39a8354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #971
internal/archive_extract.go
detectFileType()to detect archive file type (using mime sniffing)processZipFile()to extract a .zip fileinternal/archive_extract_test.go
createZipFilehelper to create a zip file fixturedoZipExtractionTesthelper to run zip assertionsTestExtractSimpleZipFiletestTestExtractAbsolutePathZipFiletestNotes:
extractArchiveset, but AFAICT NPM only serves tarballs, so PyPI is the only package manager that would use this