Solution (#3915): Dangerous Workflow: some user input are not being detected as unt - #5147
Open
TFGSUMIT wants to merge 1 commit into
Open
Solution (#3915): Dangerous Workflow: some user input are not being detected as unt#5147TFGSUMIT wants to merge 1 commit into
TFGSUMIT wants to merge 1 commit into
Conversation
…eing detected a
TFGSUMIT
requested review from
AdamKorcz and
spencerschrock
and removed request for
a team
July 28, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of untrusted user input not being detected in the
contains_untrusted_context_patternfunction. The function now correctly identifies variables containing untrusted context patterns, such as GitHub event context details that may be attacker-controlled.Changes made:
contains_untrusted_context_patternfunction to include additional GitHub event context details that may be attacker-controlled.Testing instructions:
python -m unittest checks.dangerous_workflow_test.Falsefor variables not containing untrusted context patterns.