🐛 contain git-mode file reads within the checkout root - #5164
Open
Sahana2524 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sahana Bogar <sahana@digiscrypt.com>
Sahana2524
requested review from
AdamKorcz and
justaugustus
and removed request for
a team
August 8, 2026 11:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix (security): keeps file reads in git mode inside the repository checkout.
What is the current behavior?
In git mode (
--file-mode git) the target repo is cloned to a temp dir with anon-bare
git.PlainClone, which materializes symlinks on disk for symlinkentries in the tree.
internal/gitfile'sGetFilechecks the requested name for../traversal but then reads withos.Open, which follows symlinks. A scannedrepo can commit a symlink whose name matches a check's file predicate (a workflow
file, a
Dockerfile, and so on) and make the read resolve outside the checkout:clients/git'sGetFileReaderhas the same non-bare-clone plusos.Openshapewith no containment check at all.
What is the new behavior (if this is a feature change)?
Both readers now use
os.OpenInRoot(tempDir, filename), which refuses names thatescape the root through
../or a symlink, so a within-repo path reads normallywhile an escaping one returns an error. This is the same approach
clients/localdiralready uses. A regression test commits an escaping symlinkand checks the read is refused; the existing
../traversal test still passes.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
os.OpenInRootlanded in Go 1.24 and the module is already on 1.25, so noversion bump is needed. I left the archive/zip handlers alone since they skip
symlink entries during extraction and never write them to disk, so the same read
path is not reachable there.
Does this PR introduce a user-facing change?