🐛 Packaging: recognize erlef/setup-beam for Elixir publishing workflows - #5175
Open
daniboybye wants to merge 2 commits into
Open
🐛 Packaging: recognize erlef/setup-beam for Elixir publishing workflows#5175daniboybye wants to merge 2 commits into
daniboybye wants to merge 2 commits into
Conversation
erlef/setup-elixir was renamed upstream to erlef/setup-beam (same repository; github.com/erlef/setup-elixir now redirects to it), so the existing Elixir JobMatcher no longer matches current Elixir/Hex publishing workflows that correctly use the new action name. Adds a second matcher for erlef/setup-beam alongside the existing erlef/setup-elixir one, following the same pattern already used for the two Docker matchers (docker push vs docker/build-push-action). Adds a test fixture and case exercising the new matcher; existing tests are unaffected. Signed-off-by: Daniel Urumov <danielplamenovurumov@gmail.com>
dosubot
Bot
added
the
size:S
daniboybye
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a second
PackagingJobMatcher for Elixir/Hex publishing workflows that useerlef/setup-beaminstead oferlef/setup-elixir.Why
erlef/setup-elixirwas renamed upstream toerlef/setup-beam(same repository —github.com/erlef/setup-elixirredirects togithub.com/erlef/setup-beam). The existing Elixir matcher added in #2564 only recognizes the pre-rename name, so any Elixir project correctly using the current action name getspackaging workflow not detectedeven when it has a workingmix hex.publishstep.Example: https://github.com/daniboybye/ElixirTorrent/actions/workflows/build-and-publish.yml uses
erlef/setup-beamandmix hex.publish --yesin the same job, but was scored as having no packaging workflow.How
Follows the existing pattern used for the two Docker matchers (
docker pushvsdocker/build-push-action) — adds a second, independentJobMatcherentry rather than modifying the existing one, so projects pinned to either action name are recognized.Added a test fixture (
github-workflow-packaging-elixir-setup-beam.yaml) and a correspondingTestIsPackagingWorkflowcase; existing tests and fixtures are untouched.Testing
All cases pass, including the new
elixir-setup-beamone.