✨ Analyze Makefile recipes for unpinned downloads - #5179
Open
basriakkaya wants to merge 1 commit into
Open
Conversation
Signed-off-by: Basri Akkaya <48864655+basriakkaya@users.noreply.github.com>
basriakkaya
marked this pull request as ready for review
August 14, 2026 01:37
basriakkaya
requested review from
jeffmendoza and
spencerschrock
and removed request for
a team
August 14, 2026 01:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature: extend the Dependency-Pinning check to analyze Makefile recipe commands.
What is the current behavior?
The check analyzes shell scripts, workflow
runblocks, and DockerfileRUNcommands, but it does not detect unpinned download-and-execute patterns in Makefile recipes.What is the new behavior (if this is a feature change)?
Makefile recipe commands are passed through the existing shell download validator. The implementation:
recognizes conventional Makefile names case-insensitively
ignores non-recipe syntax and recipe comments
handles Make command prefixes (
@,-, and+)joins backslash-continued recipe commands
preserves source line locations
tracks downloaded files across recipes in the same Makefile
Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
Fixes #884
Special notes for your reviewer
Validation completed:
go test ./checks/... -count=1tools/bin/golangci-lint run -c .golangci.yml --new-from-rev=HEAD(0 issues)git diff --checkThe repository-wide
make check-lintercurrently also reports two pre-existing findings outside this change inpolicy/policy.go:144(cognitive complexity) andpolicy/policy_test.go:311(field alignment).Does this PR introduce a user-facing change?