Skip to content

joystick: use 0..1 domain for game controller triggers #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcelerier merged 1 commit into from
Jun 26, 2026
Merged

joystick: use 0..1 domain for game controller triggers #906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ossia/protocols/joystick/game_controller_protocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,12 @@ void game_controller_protocol::set_device(ossia::net::device_base& dev)
if(SDL_GameControllerHasAxis(m_joystick, static_cast<SDL_GameControllerAxis>(i))
== SDL_TRUE)
{
// Triggers range from 0 to 1, while sticks range from -1 to 1.
const bool is_trigger = (i == SDL_CONTROLLER_AXIS_TRIGGERLEFT
|| i == SDL_CONTROLLER_AXIS_TRIGGERRIGHT);
m_axis_parameters[i] = device_parameter::create_device_parameter(
root, axes[i], 0.0, val_type::FLOAT, bounding_mode::CLIP, access_mode::GET,
make_domain(-1.0f, 1.0f));
is_trigger ? make_domain(0.0f, 1.0f) : make_domain(-1.0f, 1.0f));
}
}

Expand Down
Loading