Feature/wasm remote 2#1288
Closed
Toine-ddt wants to merge 20 commits into
Closed
Conversation
jcelerier
requested changes
Aug 19, 2021
| url = https://github.com/Vidvox/hap | ||
| [submodule "3rdparty/qml-remote"] | ||
| path = 3rdparty/qml-remote | ||
| url = https://github.com/ossia/qml-remote.git |
Member
There was a problem hiding this comment.
let's remove that part, we don't want this as a submodule
|
|
||
| protected: | ||
| void on_createdDocument(score::Document& doc) override; | ||
| Http_server m_server; |
jcelerier
requested changes
Aug 19, 2021
Author
|
done @jcelerier |
jcelerier
reviewed
Aug 19, 2021
jcelerier
force-pushed
the
master
branch
5 times, most recently
from
1d961e8 to
919e08a
Compare
jcelerier
force-pushed
the
master
branch
9 times, most recently
from
9a9b382 to
28c6d0a
Compare
jcelerier
force-pushed
the
master
branch
2 times, most recently
from
ac5bf9a to
fd8efed
Compare
jcelerier
force-pushed
the
master
branch
4 times, most recently
from
a402674 to
c16c15a
Compare
jcelerier
force-pushed
the
master
branch
6 times, most recently
from
ff76fa0 to
1e41cd2
Compare
Closed
Member
|
superseded by #2104 |
Member
|
(@thibaudk were all my comments here taken into account ? ) |
Member
In the process of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.