1886 feature request mouse selection and dragging of multiple processes#2052
Merged
jcelerier merged 7 commits intoJul 13, 2026
Conversation
jcelerier
force-pushed
the
1886-feature-request-mouse-selection-and-dragging-of-multiple-processes
branch
from
ab5ede4 to
f77ca84
Compare
NodeItem: respect Ctrl modifier on click — adds/removes from the
current selection instead of always replacing it. Uses filterSelections
to follow the standard GUI cumulation pattern.
NodalIntervalView: replace left-drag-to-pan with rubber-band selection.
Left button drag on empty space draws a dashed XOR selection rectangle
and selects all node items whose scene bounding rect intersects it on
release. With Ctrl held the new selection is merged into the existing
one rather than replacing it. Clicking empty space without dragging
deselects everything. Middle-button drag now pans the container,
preserving the previous pan behaviour under that button.
Nodal::View / Nodal::Presenter: same rubber-band logic for the
Nodal-process layer view. The View emits areaSelectRequested(rect,
cumulation) on mouse release; the Presenter collects every NodeItem
whose scene rect intersects the view-local rubber-band rect and pushes
the resulting Selection to the SelectionStack.
After a box or Ctrl+click multi-selection, the existing
copySelectedProcesses / pasteInCurrentInterval paths already serialise
the selected Process::ProcessModel objects as {Processes, Cables} JSON,
so Ctrl+C / Ctrl+V work without further changes.
Fixes #1886
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lection Use a QGraphicsRectItem overlay (Z=1000) instead of painting in the item's own paint() — which was either skipped due to ItemHasNoContents or rendered beneath child nodes. Box selection now requires Ctrl+drag; plain left-drag restores pan behaviour in NodalIntervalView. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…2.darker) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Using SCORE_PLUGIN_DEVICEEXPLORER_EXPORT on a symbol defined in score_plugin_nodal caused an undefined symbol linker error on platforms that build with dynamic plugins (macOS, Flatpak). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…s into a scenario When pasting processes copied from a nodal view into a clean scenario, the old code called loadProcessInSlot() (which assigns new IDs via getStrongId) but then fed cable paths that still referenced the original process IDs — causing an assertion crash in restoreCables(). Fix: track the old→new process ID mapping built during loadProcessInSlot calls, then remap cable endpoint paths before passing them to loadCables(). This keeps loadProcessInSlot (so processes appear as visible timeline slots) while fixing the ID mismatch that caused the crash. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jcelerier
force-pushed
the
1886-feature-request-mouse-selection-and-dragging-of-multiple-processes
branch
from
f77ca84 to
038ecfb
Compare
…be dragged Pressing on an already-selected node previously ran filterSelections immediately on press: with Ctrl held (required for box selection) this toggled the clicked node off, so dragging moved every selected node except the clicked one; without a modifier it collapsed the selection to the single clicked node, making it impossible to drag a multi-selection at all. Defer the selection change to the release event when the pressed node is already selected. A drag then moves the whole selection untouched, while a click without drag still applies the standard GUI behaviour (collapse to the clicked node, or toggle it off when Ctrl is held). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ScenarioEditor::remove only handled the single-element case for processes, so deleting a nodal box-selection of several processes did nothing (or only removed one). Add a branch that, when the whole selection is made of processes living in intervals, removes each of them in a single macro via the new RemoveMultipleProcessesFromInterval aggregate command. Also drop the explanatory comments added with the deferred-selection fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@jcelerier thanks for the rebase — I pushed two more commits on top of it (branch stays rebased on current master, fast-forward):
Both build cleanly here and the box-select → drag and multi-delete flows now work. Let me know if you'd prefer the multi-delete handled elsewhere than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done with Claude
Closes #1886