Scenario: fix Scale-mode tooltip modifier (Ctrl/Cmd, was Alt)#2112
Open
bltzr wants to merge 1 commit into
Open
Scenario: fix Scale-mode tooltip modifier (Ctrl/Cmd, was Alt)#2112bltzr wants to merge 1 commit into
bltzr wants to merge 1 commit into
Conversation
The Scale edition mode is toggled by holding Ctrl — ToolMenuActions::keyPressed maps Qt::Key_Control to the scale action (Qt::Key_Shift to Lock, whose tooltip is already correct). The scale action's help text advertised "Alt", which does nothing. Show the correct modifier, contextually per OS: "Cmd" on macOS (where Qt maps Key_Control to the Command key) and "Ctrl" elsewhere.
bltzr
force-pushed
the
fix/scenario-scale-tooltip-ctrl
branch
from
016b3dc to
7afe2ce
Compare
bltzr
changed the title
Member
Author
|
This one is trivial but I was confused for a moment because things were not working the way I was used to and how they were documented - the little Mac/Win distinction is a nice one to have IMHO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scale edition mode is toggled by holding Ctrl —
ToolMenuActions::keyPressedmapsQt::Key_Controlto the scale action (andQt::Key_Shiftto Lock, whose tooltip is already correct). The scale action's help text advertised "Alt", which does nothing.This shows the correct modifier, contextually per OS: Cmd on macOS (where Qt maps
Key_Controlto the ⌘ key) and Ctrl elsewhere.🤖 Generated with Claude Code
https://claude.ai/code/session_019ya5qsdZbjVtA697QUhJFz