Conversation
|
🚀 Preview deployed to https://6333e7eb.gridfinity-extended-5yu.pages.dev |
|
Not sure why it doesn't work, maybe the config merging has a bug. I will take a look tomorrow. |
| [model-template.section-model-detail.tab-metadata."Model detail"] | ||
| collapsed = true | ||
|
|
||
| [model-template.default] |
There was a problem hiding this comment.
Default template needs to be at the top
| description-extra-html = "<br><br>For detailed documentation, check the <a href='https://github.com/ostat/gridfinity_extended_openscad'>README</a>.<br><br>" | ||
|
|
||
| [model-template.bin] | ||
| template = "section-general-bin" |
There was a problem hiding this comment.
You can't use multiple templates at a time like this. Each model can only use one template. You can chain templates, so a model uses template 1 and template 1 uses template 2, but you can't combine multiple like this.
I could add that feature, but I'm not sure why you have so many templates here?
There was a problem hiding this comment.
I see that makes sense.
My reasoning was, many of the Gridfinity Extend scripts inherit from a common base, so they have shared sections, but also missing and unique sections. The non shared sections are usually because that script is not compatible with the feature.
So my thought was to have a template for each sections and add them as needed.
As an example.
| script | sections | missing sections from basic |
|---|---|---|
| Gridfinity-basic-cup | general, subdivision, wallcutout | |
| Gridfinity-sliding-lid | general, subdivision, sliding-lid | no wallcutout (its being removed) |
| Gridfinity-sive | general, sive | no floor pattern, no subdivision |
| Gridfinity-silverware | general, utensil | no subdivision |
There was a problem hiding this comment.
Okay, that makes sense. I hadn't considered that use case. I've added the ability to inherit from multiple templates at once.
Note that the template setting must be an array now, so the single string will not work anymore.
There was a problem hiding this comment.
That looks good thanks for the update
2 participants
No description provided.