Allow for connector clips on narrow baseplates - #291
Open
Lightborne wants to merge 1 commit into
Open
Conversation
Author
Here is a screenshot of the kind of thing I wanted to generate. Prior to my change, the connector clip notches would not generate. |
|
Is this the same as my issue? |
Owner
Yes, its similar, though I am not sure you want to put tabs on both sides, just the inside. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello ostat.
Disclaimer up front - this PR was written by Codex. I asked the LLM to be as minimal as possible but I am not familiar with OpenSCAD so I am not sure if this is a good implementation or not. I am happy to take any feedback to improve the change.
I made this change because I wanted to print skinny "spacer" baseplates to center my main grid within my drawer. I needed 10mm spacers on each side. The spacers were 4 gridfinity units (420mm) in length. The current implementation refused to attach connector clips because of the 10mm width, even though length-wise the geometry is fully capable of supporting it.
This change introduces a hard limit at 20mm, anything below that ran the risk of running into the curved part of the grid square. An obvious improvement would be to scale this hard limit based on the connector clip size that was entered, but I was afraid that might overcomplicate things at first.
Thanks very much for this wonderful tool!