Attempts to make it available on st3.#80
Open
glymehrvrd wants to merge 13 commits intoostinelli:masterfrom
glymehrvrd:master
Open
Attempts to make it available on st3.#80glymehrvrd wants to merge 13 commits intoostinelli:masterfrom glymehrvrd:master
glymehrvrd wants to merge 13 commits intoostinelli:masterfrom
glymehrvrd:master
Conversation
Owner
|
I see that there are a lot of changes that are related to code style preferences (for example, here), and to the fact that different spacing is used. Please adapt to code styling, provide only real changes, and stash everything into a single commit if you want me to review. Best, |
Owner
|
Also, there already is work done for ST3 here: #78. Why wasn't this good and you provided an alternative? |
Author
- remove class SublimerlGlobal, extract its methods into outter functions. + add sublimerl.py, make it the entry of this plugin. * move original *.py into package sublimerl_lib.
- man function, I use Zeal instead. + erlang parser can detect -compile([export_all]) now. + add function search, format code into context menu. * if rebar.config and ebin cannot be found, use editing file's path as root.
Author
|
@ostinelli , hi, I have tried to make my commits more tidy, see is that acceptable for u. :D |
Warning: erl_scan:token_info/2: deprecated (will be removed in OTP 19); use erl_scan:{category,column,line,location,symbol,text}/1 instead
Fix erl_scan:token_info deprecated warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have done some coding to make it available on st3.
works well on Ubuntu, test function is not tested.