Jerryp/gallery v2#665
Open
jerry-peng wants to merge 173 commits into
Open
Conversation
Fix water quality graphing code (specifically data filtering)
Fixes Server 500 when school is deleted
removed educator kits and upload resource
Edge pages now display gallery and datasheets, drop downs work
Changed code to calculate sample averages
Fixed side scrolling issues on site details (affects laptops as well)
…nents of this app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #485 637
Browser support for gallery video player:
Chrome: does not preload (good), cannot move video seek bar (bad)
Firefox: works fine, does not preload (good), seek bar works (good)
Safari (Mac): not working
Safari (Phone): not working
Edge: does not preload (good), moving seek bar requires downloading video before seeking position (bad)
Changes in this PR.
Testing this PR.
Expected Output.
@osuosl/devs