src/index: Add env var to hardcode current connections#107
Open
iakat wants to merge 1 commit intoottomated:masterfrom
iakat:patch-1
Open
src/index: Add env var to hardcode current connections#107iakat wants to merge 1 commit intoottomated:masterfrom iakat:patch-1
iakat wants to merge 1 commit intoottomated:masterfrom
iakat:patch-1
Conversation
This prevents the data from being exposed, handy for self-hosted servers.
OiYouYeahYou
suggested changes
Dec 21, 2020
| app.use(morgan('combined')) | ||
| app.use(express.static('offsets')) | ||
| let connectionCount = 0; | ||
| let publicConnectionCount = process.env.PUBLIC_CONNECTION_COUNT || connectionCount; |
There was a problem hiding this comment.
This variable will never change. In JS, with strings and numbers, you're not storing a reference, you're storing a value. If you wrapped this in an object that would work.
|
|
||
| app.get('/', (_, res) => { | ||
| res.render('index', { connectionCount, address }); | ||
| res.render('index', { publicConnectionCount, address }); |
There was a problem hiding this comment.
The template views/index.pug depends on this value. So you're breaking that template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the data from being exposed, handy for self-hosted servers.