Skip to content

Add support for twin adunits #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ourcraig wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for twin adunits #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions modules/rubiconBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ config.getConfig('rubicon', config => {

const GVLID = 52;

// Record ad units in case we need to change the adUnitCode for twins
var AD_UNIT_MAP = {};

var sizeMap = {
1: '468x60',
2: '728x90',
Expand Down Expand Up @@ -303,6 +306,21 @@ export const spec = {
if (filteredRequests && filteredRequests.length) {
const data = converter.toORTB({bidRequests: filteredRequests, bidderRequest});

// ensure unique imp IDs for twin adunits
var adUnitCodeCount = {};
data.imp = data.imp.map(function(imp) {
var adUnitCode = imp.id;
if (adUnitCodeCount[adUnitCode]) {
adUnitCodeCount[adUnitCode] += 1;
imp.id = adUnitCode + adUnitCodeCount[adUnitCode];
} else {
adUnitCodeCount[adUnitCode] = 1;
}
// update adunit map so we can translate back to original adunit code
AD_UNIT_MAP[imp.id] = adUnitCode;
return imp;
});

filteredHttpRequest.push({
method: 'POST',
url: `https://${rubiConf.videoHost || 'prebid-server'}.rubiconproject.com/openrtb2/auction`,
Expand Down Expand Up @@ -647,6 +665,14 @@ export const spec = {
if (Array.isArray(responseErrors) && responseErrors.length > 0) {
logWarn('Rubicon: Error in video response');
}
// Update seatbid for twin adunits using ad unit map
responseObj.seatbid = responseObj.seatbid.map(function(seatbid) {
seatbid.bid = seatbid.bid.map(function(bid) {
bid.impid = AD_UNIT_MAP[bid.impid] || bid.impid;
return bid;
});
return seatbid;
});
const bids = converter.fromORTB({request: data, response: responseObj}).bids;
return bids;
}
Expand Down