♻️ refacto(jq): isolate json conversion filter#262
Open
jfbus wants to merge 1 commit into
Open
Conversation
|
🔖 auto-tagging: Adding label "kind/refactoring" |
|
No diff in reference doc 😀 |
|
Binary size: 82.2MB => 82.3MB (change +4KB, +0.0%) 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The jq filter does a JSON to/from conversion to convert the input to a json.RawMessage format supported by the gojq package.
When multiple jq filters are applied, this leads to redundant/useless conversions. This PR isolates the JSON conversion to a separate filter that is applied before jq filters..
Type of Change
Please check the relevant option(s):
How Has This Been Tested?
Please describe the test strategy:
Checklist
Additional Context