♻️refactor: rework patches and breaking change handling#29
Merged
Conversation
Digging knwoladge back from hacks as well as trying to make it easier to maintain, understand and modify. the main goal is to centralise workarounds and knowladge about why they exists and how they came to be. The secondary goal was to reduce the amount of state to make is reproductible without rolling back old-outscale.yaml Upgrading Ruby from 3.0 to 3.3 in the process, as well as resionalise shebangs to make it more nix-shell frendly.
Add Dockerfile to build container that could be used in other sdk builder. The rationnals is that each sdk should patch openapi spec for their own benefits. Fix no date-time patch to remove format in array as well.
Previous attempts prove to be limited because their are too generaliste. introducing a new patch finishing to reduce divengence between implementations
Previous implementation relie on a state `old-outscale.yaml` for doing type backporting which result in inconsistant implementation in SDKs and the unability to re-run easeliy the workflow. This now implementation relis on a stateless aproche and a more modulare implementaions of hacks. In a ideal world, patches should be declared in the builder on each SDK and this repositorie whould only be a workflow dispatcher and a toolbox. However, for backward compabilility of present workflow, all patches ,`build.sh` and build artifacts (outscale.yaml, outscale-*.yaml) are still commited to this repositorie for now. A Workflow have also been added to avoid future bracking chages as well
jfbus
reviewed
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation relied on a stateful
old-outscale.yamlfile for type backporting, which resulted in inconsistent implementations and made it difficult to re-run the workflow reliably.The new implementation adopt a stateless approach and introduces a more modular structure for applying hacks.
Ideally, patches should be declared within each SDK's builder and this repository should serve solely as a workflow
orchestrator and toolbox.
However, for backward compatibility with the current workflow, all patches , the
build.shscript, and build artifacts (outscale.yaml,outscale-*.yaml) are still committed to this repository for now.Additionally, a workflow has been added to prevent future breacking changes.