Fixes for unit tests#2243
Merged
daleglass merged 9 commits intooverte-org:masterfrom May 2, 2026
Merged
Conversation
Fixes overte-org#2231 We discussed this at a dev meeting and decided the error is small enough as not to be a concern.
ksuprynowicz
approved these changes
May 2, 2026
Member
ksuprynowicz
left a comment
ksuprynowicz
left a comment
There was a problem hiding this comment.
Thank you! Everything looks good :)
ksuprynowicz
added
the
CR approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of unit tests.
Unit tests have been languishing a bit, so mostly it's the tests themselves that are broken and need to be brought up to date, or were never right to start with.
Once we have working tests we can make them part of CI and expand them.
So far: