Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No open issue, this is a quick change intended to prevent a server crashing error case.
This adds error handling to an the async commit processor. This function runs on the server after a commit is requested. The requesting client will not be awaiting the response, which means there are no error handlers in place to catch thrown errors from this function.
These changes provide a very rudimentary error handler that will log that an error has occurred for the commit of the given submission. Any message in the thrown error will also be logged.
Data Provider
performCommitSubmissionAsyncReadiness Checklist
.env.schemafile and documented in the README