Skip to content

Add Error Handling to commit async processor#190

Open
joneubank wants to merge 1 commit intomainfrom
fix/catch-commit-errors
Open

Add Error Handling to commit async processor#190
joneubank wants to merge 1 commit intomainfrom
fix/catch-commit-errors

Conversation

@joneubank
Copy link
Contributor

Summary

No open issue, this is a quick change intended to prevent a server crashing error case.

This adds error handling to an the async commit processor. This function runs on the server after a commit is requested. The requesting client will not be awaiting the response, which means there are no error handlers in place to catch thrown errors from this function.

These changes provide a very rudimentary error handler that will log that an error has occurred for the commit of the given submission. Any message in the thrown error will also be logged.

Data Provider

  • Submission Processr
    • Provide error handling for performCommitSubmissionAsync

Readiness Checklist

  • Self Review
    • I have performed a self review of code
    • I have run the application locally and manually tested the feature
    • I have checked all updates to correct typos and misspellings
  • Formatting
    • Code follows the project style guide
    • Autmated code formatters (ie. Prettier) have been run
  • Local Testing
    • Successfully built all packages locally
    • Successfully ran all test suites, all unit and integration tests pass
  • Updated Tests
    • Unit and integration tests have been added that describe the bug that was fixed or the features that were added
  • Documentation
    • All new environment variables added to .env.schema file and documented in the README
    • All changes to server HTTP endpoints have open-api documentation
    • All new functions exported from their module have TSDoc comment documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant