Open
Conversation
This work is based on the function that had been written and removed in commit: e24f7d6 This leaves the data provider with the existing submit functionality described as submitting single entity data. The new submit endpoint allows submitting files with filenames matching teh entity name.
joneubank
requested review from
MitchellShiell,
justincorrigible and
leoraba
joneubank
commented
Feb 15, 2026
Comment on lines
+67
to
+75
| /** | ||
| * Processes a list of data records and compares them with previously submitted data. | ||
| * @param {DataRecord[]} records An array of data records to be processed | ||
| * @param {string} schemaName The name of the schema associated with the records | ||
| * @returns {Promise<SubmissionUpdateData[]>} An array of `SubmissionUpdateData` objects. Each object | ||
| * contains the `systemId`, `old` data, and `new` data representing the differences | ||
| * between the previously submitted data and the updated record. | ||
| */ | ||
| const compareUpdatedData = async (records: DataRecord[], schemaName: string): Promise<SubmissionUpdateData[]> => { |
Contributor
Author
There was a problem hiding this comment.
Moved up file, sorting alphabetically.
Comment on lines
+766
to
+776
| /** | ||
| * Update Active Submission in database | ||
| * @param {Object} input | ||
| * @param {number} input.dictionaryId The Dictionary ID of the Submission | ||
| * @param {SubmissionData} input.submissionData Data to be submitted grouped on inserts, updates and deletes | ||
| * @param {number} input.idActiveSubmission ID of the Active Submission | ||
| * @param {SubmissionErrors} input.schemaErrors Array of schemaErrors | ||
| * @param {string} input.username User updating the active submission | ||
| * @returns {Promise<number>} An Active Submission updated | ||
| */ | ||
| const updateActiveSubmission = async (input: { |
Contributor
Author
There was a problem hiding this comment.
Moved down file. Large edits are from moving blocks of code around.
Contributor
Author
There was a problem hiding this comment.
File utilities restored from removed file upload code.
Contributor
Author
There was a problem hiding this comment.
Many interfaces and types renamed to match TitleCase standard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore data submission by file upload.
Important
This PR will require a major version release since it modifies API endpoint interfaces, and renames some of the exported properties of the submission service and controller.
Issues
Description of Changes
Data submission via file upload was removed in commit e24f7d6 , but it is desired behaviour. With these changes, the lyric server can now accept data submissions by file upload or by JSON in the request body through two separate endpoints.
A new endpoint was added to upload files for data submission.
The submission router has had the existing submit endpoint be moved to now include the entityName in the path, so this has become a "submit for single entity" endpoint. To match these changes, the edit submission endpoint was also moved to match the path of the submit for single entity. This follows the philosophy that required parameters should be in the path or body of the request instead of query parameters.
Data-Provider (Lyric npm library)
Server
config/app.tson defining the AppConfig instead of process.env parsing.Readiness Checklist
.env.schemafile and documented in the README