Fix SOS Dependency Checks and Fix -L Flag in Build Configuration#1908
Fix SOS Dependency Checks and Fix -L Flag in Build Configuration#1908spwalto wants to merge 4 commits into
Conversation
spwalto
changed the title
spwalto
force-pushed
the
config_flag_fixes
branch
from
7d632e0 to
02a0ef8
Compare
spwalto
changed the title
|
@baallan could you please take a look at this? |
|
when tested under toss4, the m4 change isn't generating correct code for the gpcdlocal test or (afaict) the sosdb test. there's a bunch of other stuff changing in configure.ac as well, so it may be a little bit before i untangle my understanding of where the rest of the changes are intended to get us and what is just a bug. |
|
@spwalto if you use the --with-sos= Does the problem go away? |
Yes, the LDMS builds successfully. I'll go ahead and remove the changes to options.m4. Thank you for looking into this! |
spwalto
force-pushed
the
config_flag_fixes
branch
from
1c899cd to
b6bd506
Compare
|
|
||
| # Now check if SOS is enabled | ||
| if test -n "$ENABLE_SOS_TRUE" && test -n "$missing"; then | ||
| AC_MSG_ERROR([The following features require --enable-sos:$missing. Please re-run configure with --enable-sos.]) |
There was a problem hiding this comment.
@spwalto, I think the error should be --with-sos=PATH is required, please re-run with this configure option.
The --enable-sos is not correct. We should probably remove it.
There was a problem hiding this comment.
Ah, yes — you’re right. I had forgotten about the changes made to the Makefile.am. I’ve updated the file to remove the ENABLE_SOS_TRUE check and changed the error message to output --with-sos=PATH (or --with-sos=) . The LDMS build & install was tested with the --with-sos flag and there were no issues.
There was a problem hiding this comment.
I was able to successfully build with these new changes on @spwalto fork. This looks fine by me.
|
Pipelines all look good on our end. @tom95858, unless there’s something I missed in the latest updates, this PR should be good to merge. |
5 participants
This fixes issue #1864 - In
ldms/src/store/Makefile.am, the SOS-dependent plugins now follow the same format as theif ENABLE_KOKKOSblock for consistency.While testing, I ran into this error:
libtool: error: require no space between '-L' and '../../../../ldms/src/core/libldms.la'.After digging into it, I found the issue was with
m4/options.m4—it was setting-Lflags even when the specified directories didn’t exist. In my case, I was using a local SOS build where the library lived underbuild/sos/src/.libs/, so the default/liband/lib64checks failed, and the script ended up setting-Lwith no path.To fix this, I updated
options.m4so that the*_LIB64DIR_FLAGand*_LIBDIR_FLAGare only set if the corresponding directories actually exist. Otherwise, they’re left empty.