Skip to content

📜 agriculture: Set food trade technical piece ready for publication#6322

Draft
pabloarosado wants to merge 33 commits into
masterfrom
docs-foodtrade-publishready
Draft

📜 agriculture: Set food trade technical piece ready for publication#6322
pabloarosado wants to merge 33 commits into
masterfrom
docs-foodtrade-publishready

Conversation

@pabloarosado

@pabloarosado pabloarosado commented Jun 19, 2026

Copy link
Copy Markdown
Contributor
  • Improve technical publication on food trade.
  • Add missing item (soybean cake used for feed).

@owidbot

owidbot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs Docs Preview

Login: ssh owid@staging-site-docs-foodtrade-publishready

chart-diff: ✅ No charts for review.
data-diff: ❌ Found differences
= Dataset garden/faostat/2026-05-07/food_trade
  = Table food_trade
    ~ Dim exporter
+       + New values: 1386 / 296974 (0.47%)
                    importer                  item  item_code  year      exporter
                       Japan Soybean meal for feed        238  2023         China
                    Slovenia Soybean meal for feed        238  2023         Italy
                      Sweden Soybean meal for feed        238  2023      Slovenia
                      Jordan Soybean meal for feed        238  2023       Ukraine
          Dominican Republic Soybean meal for feed        238  2023 United States
    ~ Dim importer
+       + New values: 1386 / 296974 (0.47%)
               exporter                  item  item_code  year           importer
                  China Soybean meal for feed        238  2023              Japan
                  Italy Soybean meal for feed        238  2023           Slovenia
               Slovenia Soybean meal for feed        238  2023             Sweden
                Ukraine Soybean meal for feed        238  2023             Jordan
          United States Soybean meal for feed        238  2023 Dominican Republic
    ~ Dim item
+       + New values: 1386 / 296974 (0.47%)
               exporter           importer  item_code  year                  item
                  China              Japan        238  2023 Soybean meal for feed
                  Italy           Slovenia        238  2023 Soybean meal for feed
               Slovenia             Sweden        238  2023 Soybean meal for feed
                Ukraine             Jordan        238  2023 Soybean meal for feed
          United States Dominican Republic        238  2023 Soybean meal for feed
    ~ Dim item_code
+       + New values: 1386 / 296974 (0.47%)
               exporter           importer                  item  year  item_code
                  China              Japan Soybean meal for feed  2023        238
                  Italy           Slovenia Soybean meal for feed  2023        238
               Slovenia             Sweden Soybean meal for feed  2023        238
                Ukraine             Jordan Soybean meal for feed  2023        238
          United States Dominican Republic Soybean meal for feed  2023        238
    ~ Dim year
+       + New values: 1386 / 296974 (0.47%)
               exporter           importer                  item  item_code  year
                  China              Japan Soybean meal for feed        238  2023
                  Italy           Slovenia Soybean meal for feed        238  2023
               Slovenia             Sweden Soybean meal for feed        238  2023
                Ukraine             Jordan Soybean meal for feed        238  2023
          United States Dominican Republic Soybean meal for feed        238  2023
    ~ Column exporter_production (new data)
+       + New values: 1386 / 296974 (0.47%)
               exporter           importer                  item  item_code  year  exporter_production
                  China              Japan Soybean meal for feed        238  2023           79023232.0
                  Italy           Slovenia Soybean meal for feed        238  2023            2223200.0
               Slovenia             Sweden Soybean meal for feed        238  2023                 <NA>
                Ukraine             Jordan Soybean meal for feed        238  2023            1236600.0
          United States Dominican Republic Soybean meal for feed        238  2023           48992000.0
    ~ Column importer_supply (new data)
+       + New values: 1386 / 296974 (0.47%)
               exporter           importer                  item  item_code  year  importer_supply
                  China              Japan Soybean meal for feed        238  2023             <NA>
                  Italy           Slovenia Soybean meal for feed        238  2023      254661.8125
               Slovenia             Sweden Soybean meal for feed        238  2023       184152.625
                Ukraine             Jordan Soybean meal for feed        238  2023     384454.03125
          United States Dominican Republic Soybean meal for feed        238  2023     297423.53125
    ~ Column value (new data)
+       + New values: 1386 / 296974 (0.47%)
               exporter           importer                  item  item_code  year         value
                  China              Japan Soybean meal for feed        238  2023      576674.0
                  Italy           Slovenia Soybean meal for feed        238  2023   4815.850098
               Slovenia             Sweden Soybean meal for feed        238  2023          0.37
                Ukraine             Jordan Soybean meal for feed        238  2023  11531.820312
          United States Dominican Republic Soybean meal for feed        238  2023  268944.78125


Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2026-06-23 10:58:02 UTC
Execution time: 17.50 seconds

pabloarosado and others added 26 commits June 19, 2026 22:33
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Load tables from the public OWID catalog so the notebook runs without an
  ETL checkout (e.g. Colab); silence the catalog loader spinner
- Add a country reporting-rate choropleth (Robinson projection, binned
  horizontal legend) and factor out a shared reporting-rate helper
- Show the 15 best- and 15 worst-reported food items, one bar per item
- Clarify prose (define "bilateral", reword the reporting-agreement intro)
- Replace notebook print output with silent assertions

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Downsized to 1600px / ~127kB (from ~400kB) via palette PNG; no quality loss at display size.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@pabloarosado pabloarosado self-assigned this Jun 23, 2026
@pabloarosado

Copy link
Copy Markdown
Contributor Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the “Global food trade data” technical publication visible in the docs navigation/publications index and extends the FAOSTAT food trade item dropdown configuration with a missing soybean-cake-derived item.

Changes:

  • Enable the “Global food trade data” entry in the docs nav (zensical.toml).
  • Unhide the “Global food trade data” section on the technical publications index page.
  • Add FAOSTAT item code 238 (“Cake of soya beans”) to the curated food-trade item list.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

File Description
zensical.toml Adds “Global food trade data” to the published navigation under Technical publications.
etl/steps/data/garden/faostat/2026-05-07/food_trade.items.yaml Adds a new curated item entry mapping code 238 for inclusion in the food-trade dropdown.
docs/analyses/index.md Removes the HTML comment wrapper so the food trade publication section is listed on the index page.

Comment thread etl/steps/data/garden/faostat/2026-05-07/food_trade.items.yaml
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

"assert len(tb) > 25e-6\n",

P2 Badge Require millions of tonne rows after filtering

This sanity check is meant to confirm that filtering to tonne quantity rows leaves roughly 26 million records, but 25e-6 is only 0.000025, so any non-empty result passes. If the catalog schema or unit labels change and the filter keeps only a tiny subset, the notebook can still execute and publish misleading downstream charts; the threshold should be 25e6.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants