ci: fix ci.yml branch triggers on 8.1 branch - #1292
Merged
Merged
Conversation
The 8.1 ci.yml was copied from master without adjusting its triggers: pull_request.branches pointed at master and push.branches omitted 8.1, so PRs against 8.1 and pushes to 8.1 never built the docs. GitHub matches branches: against the ref the event fires on, so the filter must name 8.1. Make both push and pull_request self-referential to 8.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This was referenced Jul 15, 2026
mmattel
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the
push/pull_requestbranch filters in.github/workflows/ci.ymlon the8.1branch so CI actually runs for this release line.Why (this is a real bug, not just cleanup)
8.1'sci.ymlwas copied frommasterwithout adjusting its triggers:pull_request.brancheswasmaster→ PRs targeting8.1never ran the docs buildpush.brancheswasmaster, 8.0, 7.3(no8.1) → pushes to8.1never ran eitherGitHub Actions matches the
branches:filter against the ref the event fires on, using theci.ymlthat lives on that ref — so the filter on the8.1branch must name8.1.Part of a coordinated cleanup making each branch's
ci.ymlself-referential (companion PRs: #1291 formaster, plus8.0and7.3).Change
push.branches:master, 8.0, 7.3→'8.1'pull_request.branches:master→'8.1'No
jobs:changes.Verification
After this PR opens, the Build documentation check should appear and run against it — before this fix it does not run at all.
🤖 Generated with Claude Code