[fix/markup-pinch-acc-dismiss] Prevent accidental dismissal of markup UI via pinch gesture

[felix-schwarz]

Description

Prevents the accidental dismissal of markup UI via pinch gesture.

Related Issue

SE-1419

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[jesmrec]

Problem is easily reproducible, some checks performed over iPhone and iPad, PDF and image files (markupable formats) to confirm that the pinch action does not close the mark-up mode accidentally.

Approved on my side.

[dj4oC]

This PR prevents accidental dismissal of the markup UI via a pinch gesture, by setting isModalInPresentation = true on the presented edit-document view controller.

Findings

Nothing blocking. Already reviewer-tested on-device (iPhone + iPad, PDF and image/markupable formats) and approved by three reviewers, including an explicit QA sign-off in the PR comments.

One informational (non-blocking) note: isModalInPresentation is set on editDocumentViewController — the navigation controller's root — rather than on the presented navigationController itself. iOS's interactive-dismissal check normally consults the presented view controller. Since on-device QA already confirms the pinch-to-dismiss gesture is blocked as intended, this is very likely fine in practice (the pinch handler probably checks the flag directly rather than relying on system sheet-dismissal semantics) — flagging only so a future reviewer double-checks which VC is authoritative here if this pattern is reused elsewhere.

Note

Build verification skipped (Xcode not available in cloud review environment). Code analysis only.

Verdict

Commenting — no blocking findings; already approved by 3 reviewers including QA.

🤖 Automated review by Claude Code (security · stability · performance · coverage)

---

Generated by Claude Code

[dj4oC]

• Security: no findings
• Stability: no findings
• Performance: no findings
• Test coverage: N/A — 1-line UI fix, no automated test added; manually verified on-device by QA (iPhone + iPad, PDF/image markup) per PR comments
• TODOs found: none
• Dependency touched: no
• CI status: all green
• Stale review: no — already approved by 3 reviewers including QA sign-off

🤖 Automated review by Claude Code (security · stability · performance · coverage)

---

Generated by Claude Code