Open
Conversation
djtuBIG-MaliceX
commented
Jan 6, 2021
Author
djtuBIG-MaliceX
left a comment
djtuBIG-MaliceX
left a comment
There was a problem hiding this comment.
Would like some thoughts from anyone else. While this will address the immediate integer overflow distortion issue as tested, it does not address other deficiencies such as the fact stereo signals are downmixed to mono reverb.
|
|
||
| #ifdef _WIN32 | ||
| #define snprintf _snprintf | ||
| //#define snprintf _snprintf |
Author
There was a problem hiding this comment.
I had to comment this out as it was failing to build under MSYS2 MinGW-w64. This seems like a dirty hack anyway that likely no longer applies with more recent versions of MinGW-w64 GCC compiler suite.
| in1 = smp; | ||
| smp = ou0>>2; | ||
|
|
||
| b[i] = (smp > INT_MAX) ? INT_MAX : |
Author
There was a problem hiding this comment.
Thinking more work might be needed to prevent double-clipping.
djtuBIG-MaliceX
commented
Jan 6, 2021
| b[i] = ou0l; | ||
| ou0l = ((smp * a0)/32768) + ((in1l * a1)/32768) + ((ou0l * b1)/32768); | ||
| in1l = smp; | ||
| b[i] = (ou0l > INT_MAX) ? INT_MAX : |
Author
There was a problem hiding this comment.
As above, this may contribute to double-clipping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address Issue #16