Bump hyper-rustls from 0.25.0 to 0.27.3 by dependabot[bot] · Pull Request #1110 · oxidecomputer/dropshot

dependabot · 2024-09-09T05:00:49Z

Bumps hyper-rustls from 0.25.0 to 0.27.3.

Release notes

v/0.27.3

What's Changed

fix: add rustls-platform-verifier flag for importing ConfigBuilderExt by @junkurihara in rustls/hyper-rustls#276

docs: add a feature rustls-platform-verifier in the list of README.md by @junkurihara in rustls/hyper-rustls#277

Bump seanmiddleditch/gha-setup-ninja from 4 to 5 by @dependabot in rustls/hyper-rustls#278

Bump MSRV to 1.70 (for tokio 1.39) by @djc in rustls/hyper-rustls#281

Builder fixes by @Gelbpunkt in rustls/hyper-rustls#283

enable rustls-platform-verifier for docs.rs by @flisky in rustls/hyper-rustls#279

Upgrade to rustls-native-certs 0.8 by @djc in rustls/hyper-rustls#285

0.27.2

What's Changed

ci: use ubuntu-latest instead of ubuntu-20.04 by @djc in rustls/hyper-rustls#271

Avoid aws-lc-rs feature flag when building docs. by @tobz in rustls/hyper-rustls#273

Bump version to 0.27.2 by @djc in rustls/hyper-rustls#275

0.27.1

Added

New ConnectorBuilder::with_server_name_resolver() fn for specifying an implementation of the ResolveServerName trait to dynamically resolve the subject name used when verifying a server's certificate.

New fips feature flag for enabling the aws-lc-rs Rustls crypto provider in FIPS mode.

Changed

ConnectorBuilder::with_server_name() is now deprecated. Existing usages should be replaced with ConnectorBuilder::with_server_name_resolver() and a FixedServerNameResolver.

What's Changed

Add feature flag for enabling FIPS. by @tobz in rustls/hyper-rustls#268

Support custom server name resolution by @sfackler in rustls/hyper-rustls#269

Cargo: v0.27.0 -> v0.27.1 by @cpu in rustls/hyper-rustls#270

New Contributors

@tobz made their first contribution in rustls/hyper-rustls#268

@sfackler made their first contribution in rustls/hyper-rustls#269

Full Changelog: rustls/hyper-rustls@v/0.27.0...v/0.27.1

0.27.0

Changed

Rustls updated to 0.23

Default cryptography provider changed to aws-lc-rs to match upstream Rustls project. Note that this has some implications on platform support and build-time tool requirements such as cmake on all platforms and nasm on Windows. Support for ring continues to be available: set the ring crate feature.

Added

New with_platform_verifier connector builder fns for using rustls-platform-verifier for certificate verification. Requires the optional rustls-platform-verifier feature be enabled.

New HttpsConnector::builder fn for conveniently constructing a ConnectorBuilder.

... (truncated)

Commits

dc54bc0 Bump version to 0.27.3
a1d9263 Import std::io directly
6d1267c Avoid io::Result type alias
139550b Upgrade to rustls-native-certs 0.8
516e3ac Alphabetically sort features
3a4d5d7 Move features before dependencies
f8c2036 chore: sort features
1d57d93 enable rustls-platform-verifier for docs.rs
a6a5687 Take impl Into<Arc> in connector builder
b4f5132 Add ConnectorBuilder::with_provider_and_platform_verifier
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [hyper-rustls](https://github.com/rustls/hyper-rustls) from 0.25.0 to 0.27.3. - [Release notes](https://github.com/rustls/hyper-rustls/releases) - [Commits](rustls/hyper-rustls@v/0.25.0...v/0.27.3) --- updated-dependencies: - dependency-name: hyper-rustls dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

ahl · 2024-09-26T18:57:53Z

@dependabot recreate

Bumps [hyper-rustls](https://github.com/rustls/hyper-rustls) from 0.25.0 to 0.27.3. - [Release notes](https://github.com/rustls/hyper-rustls/releases) - [Commits](rustls/hyper-rustls@v/0.25.0...v/0.27.3) --- updated-dependencies: - dependency-name: hyper-rustls dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…decomputer/dropshot into dependabot/cargo/hyper-rustls-0.27.3

ahl · 2024-09-27T15:32:11Z

This turns out to be a broken on illumos--interesting!

ahl

I imagine we'll want to test that omicron works at all with this stuff rather than landing in a spot where dropshot has a required dependency that's broken for us

ahl · 2024-09-27T16:23:46Z

dropshot/Cargo.toml

 multer = "3.1.0"
 paste = "1.0.15"
 percent-encoding = "2.3.1"
-rustls = "0.22.4"


these remove the default dependency on aws-lc-rs... which does not build on illumos

Maybe add a comment here explaining why we're disabling this? Whether it's the short-term reason that aws-lc-rs doesn't build on illumos or a long-term preference to avoid it.

ahl · 2024-09-27T16:24:07Z

dropshot/Cargo.toml

 buf-list = "1.0.3"
 expectorate = "1.1.0"
-hyper-rustls = "0.26.0"
+hyper-rustls = { version = "0.27.3", default-features = false, features = ["http1", "ring"] }


this adds what we need for testing across platforms

davepacheco · 2024-09-27T18:36:29Z

From offline discussion I gathered a bit more context I wanted to leave here for the record:

Previously hyper-rustls used ring for crypto. In this update, hyper-rustls includes support for both ring and aws-lc-rs, with the latter being the default.
The released version of aws-lc-rs does not build on illumos due to support building on illumos systems aws/aws-lc#1854. This fix was landed but not yet released.
Disabling the features in various rustls-related crates here prevents us from pulling in the broken aws-lc-rs, which allows this to build. This also makes it easier (possible?) for consumers to decide which of the rustls crypto backends it wants to use based on what features they choose.

davepacheco · 2024-09-27T18:30:40Z

dropshot/Cargo.toml

 multer = "3.1.0"
 paste = "1.0.15"
 percent-encoding = "2.3.1"
-rustls = "0.22.4"


Maybe add a comment here explaining why we're disabling this? Whether it's the short-term reason that aws-lc-rs doesn't build on illumos or a long-term preference to avoid it.

davepacheco · 2024-09-27T18:30:49Z

dropshot/Cargo.toml

 slog-json = "2.6.1"
 slog-term = "2.9.1"
-tokio-rustls = "0.25.0"
+tokio-rustls = { version = "0.26.0", default-features = false }


Another comment here maybe?

davepacheco · 2024-09-27T18:30:57Z

dropshot/Cargo.toml

 buf-list = "1.0.3"
 expectorate = "1.1.0"
-hyper-rustls = "0.26.0"
+hyper-rustls = { version = "0.27.3", default-features = false, features = ["http1", "ring"] }


Another comment here maybe?

ahl · 2024-09-28T18:32:03Z

We need one of the crypto algorithms enabled by default or else consumers who don't have rustls as an explicit dep will encounter a runtime failure

dependabot bot added the dependencies Pull requests that update a dependency file label Sep 9, 2024

dependabot bot mentioned this pull request Sep 9, 2024

Bump hyper-rustls from 0.25.0 to 0.27.2 #1057

Closed

dependabot bot force-pushed the dependabot/cargo/hyper-rustls-0.27.3 branch from 0f18ee1 to aeb7d64 Compare September 26, 2024 18:55

dependabot bot force-pushed the dependabot/cargo/hyper-rustls-0.27.3 branch from aeb7d64 to 05630e6 Compare September 26, 2024 18:58

dependabot bot force-pushed the dependabot/cargo/hyper-rustls-0.27.3 branch from 05630e6 to b558b82 Compare September 26, 2024 19:10

ahl added 3 commits September 26, 2024 12:27

update rustls and tokio-rustls as well

488fb8a

Merge branch 'dependabot/cargo/hyper-rustls-0.27.3' of github.com:oxi…

935a362

…decomputer/dropshot into dependabot/cargo/hyper-rustls-0.27.3

lock

84c4293

ahl self-assigned this Sep 27, 2024

ahl added 3 commits September 27, 2024 08:39

avoid pulling in aws-lc-rs by disabling rustls features

700b26d

be delicate with features

d0eb686

add deps in test; allow dropshot consumers to choose flags for rustls

9382813

ahl requested a review from davepacheco September 27, 2024 16:23

ahl reviewed Sep 27, 2024

View reviewed changes

davepacheco reviewed Sep 27, 2024

View reviewed changes

ahl marked this pull request as draft September 28, 2024 18:32

davepacheco mentioned this pull request Oct 1, 2024

add builder interface for making servers #1122

Merged

ahl mentioned this pull request Jan 14, 2026

Update tokio-rustls #1470

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump hyper-rustls from 0.25.0 to 0.27.3#1110

Bump hyper-rustls from 0.25.0 to 0.27.3#1110
dependabot[bot] wants to merge 8 commits intomainfrom
dependabot/cargo/hyper-rustls-0.27.3

dependabot bot commented on behalf of github Sep 9, 2024 •

edited

Loading

Uh oh!

ahl commented Sep 26, 2024

Uh oh!

ahl commented Sep 27, 2024

Uh oh!

ahl left a comment

Uh oh!

ahl Sep 27, 2024

Uh oh!

davepacheco Sep 27, 2024

Uh oh!

ahl Sep 27, 2024

Uh oh!

davepacheco commented Sep 27, 2024

Uh oh!

davepacheco Sep 27, 2024

Uh oh!

davepacheco Sep 27, 2024

Uh oh!

davepacheco Sep 27, 2024

Uh oh!

ahl commented Sep 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dependabot bot commented on behalf of github Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v/0.27.3

What's Changed

0.27.2

What's Changed

0.27.1

Added

Changed

What's Changed

New Contributors

0.27.0

Changed

Added

Uh oh!

ahl commented Sep 26, 2024

Uh oh!

ahl commented Sep 27, 2024

Uh oh!

ahl left a comment

Choose a reason for hiding this comment

Uh oh!

ahl Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

davepacheco Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

ahl Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

davepacheco commented Sep 27, 2024

Uh oh!

davepacheco Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

davepacheco Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

davepacheco Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

ahl commented Sep 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dependabot bot commented on behalf of github Sep 9, 2024 •

edited

Loading