Merged
Conversation
9 tasks
nathanaelhuffman
force-pushed
the
ndh/espi-vis
branch
from
4f4db79 to
5001b0d
Compare
nathanaelhuffman
changed the title
jgallagher
approved these changes
Feb 12, 2026
Contributor
jgallagher
left a comment
jgallagher
left a comment
There was a problem hiding this comment.
Tested on a cosmo in london
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a usedwds truncation bug in eSPI that would result in 1 or 0 byte espi transfers that cause a lot of backpressure and sadness.
Fix a backpressure bug where UART backpressure could result in a lost byte due to the FPGA not dropping the hw-handshake before the buffer was full.
We add more eSPI register visibility for debugging.
There's a minor change here to the register generator to allow enums <= 8 bits as the original assert was too strict.