convert to new dropshot builder interface#6730
Merged
davepacheco merged 21 commits intomainfrom Nov 14, 2024
Merged
Conversation
Collaborator
Author
|
|
…dap/drafts/dropshot-update
…dap/drafts/dropshot-update
davepacheco
changed the title
davepacheco
force-pushed
the
dap/dropshot-builder
branch
2 times, most recently
from
7841c5b to
534f0fe
Compare
… dap/dropshot-builder
davepacheco
force-pushed
the
dap/dropshot-builder
branch
from
534f0fe to
5895d1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates all Dropshot consumers in Omicron to use the new
ServerBuilderinterface instead of the oldHttpServerStarterinterface.(This PR started as part of oxidecomputer/dropshot#1122. Although that should be a non-breaking change, I wanted to test-convert all of Omicron over to the new thing to make sure I didn't run into any unexpected issues. This worked out pretty well (and there were no callers that didn't immediately invoke
start()on theHttpServerStarter).)