Skip to content

feat: add starlark support #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lf- wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add starlark support #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,17 @@ function normalizeFileType(f: FileDiffMetadata): FileDiffMetadata {
return f
}

const STARLARK_EXTS = new Set(['bzl', 'bxl', 'sky', 'star', 'bazel'])
const STARLARK_BASES = new Set(['BUCK', 'BUILD', 'PACKAGE', 'Tiltfile'])

// Starlark has no dedicated shiki grammar; Python is close enough.
function applyLangOverride(f: FileDiffMetadata): FileDiffMetadata {
const base = f.name.split('/').pop() ?? f.name
const ext = base.includes('.') ? base.split('.').pop() : undefined
if ((ext && STARLARK_EXTS.has(ext)) || STARLARK_BASES.has(base)) f.lang = 'python'
return f
}

function getFileStats(fileDiff: FileDiffMetadata) {
let additions = 0
let deletions = 0
Expand Down Expand Up @@ -949,6 +960,7 @@ function DiffView() {
? parsePatchFiles(patch)
.flatMap((p) => p.files)
.map(normalizeFileType)
.map(applyLangOverride)
: [],
[patch],
)
Expand Down Expand Up @@ -1028,11 +1040,13 @@ function DiffView() {
// context: 3 matches git's default so the visible context doesn't jump
// when a file upgrades from its patch parse to the full-content diff.
// Expand-all uses whole-file context so the entire file shows as one hunk.
const diff = normalizeFileType(
parseDiffFromFile(
{ name: f.prevName ?? f.name, contents: c.oldContents ?? '' },
{ name: f.name, contents: c.newContents ?? '' },
{ context: isExpanded ? Number.MAX_SAFE_INTEGER : 3 },
const diff = applyLangOverride(
normalizeFileType(
parseDiffFromFile(
{ name: f.prevName ?? f.name, contents: c.oldContents ?? '' },
{ name: f.name, contents: c.newContents ?? '' },
{ context: isExpanded ? Number.MAX_SAFE_INTEGER : 3 },
),
),
)
parsedCacheRef.current.set(f.name, {
Expand Down