Update dependency sequelize to v6.37.8 [SECURITY]#74
Open
renovate[bot] wants to merge 1 commit intomasterfrom
Open
Update dependency sequelize to v6.37.8 [SECURITY]#74renovate[bot] wants to merge 1 commit intomasterfrom
renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
ff6ceff to
0cfb26d
Compare
0cfb26d to
b96725d
Compare
b96725d to
bf0f015
Compare
bf0f015 to
694581a
Compare
694581a to
507bef2
Compare
507bef2 to
ec4982a
Compare
ec4982a to
ff3032f
Compare
ff3032f to
37fd650
Compare
37fd650 to
1941d40
Compare
1941d40 to
337b0bc
Compare
337b0bc to
edd4c17
Compare
edd4c17 to
6be8314
Compare
6be8314 to
4b24d15
Compare
4b24d15 to
3741b65
Compare
3741b65 to
4c0cfbe
Compare
4c0cfbe to
95ac3b8
Compare
95ac3b8 to
f9f3bce
Compare
f9f3bce to
d940b5c
Compare
d940b5c to
f9fe9fd
Compare
52995a4 to
ae9a456
Compare
ae9a456 to
9fe83e0
Compare
b150457 to
84672d8
Compare
379b412 to
6b392eb
Compare
6b392eb to
4ede947
Compare
4ede947 to
480fa65
Compare
480fa65 to
0531430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
6.5.0→6.37.8GitHub Vulnerability Alerts
CVE-2023-25813
Impact
The SQL injection exploit is related to replacements. Here is such an example:
In the following query, some parameters are passed through replacements, and some are passed directly through the
whereoption.This is a very legitimate use case, but this query was vulnerable to SQL injection due to how Sequelize processed the query: Sequelize built a first query using the
whereoption, then passed it over tosequelize.querywhich parsed the resulting SQL to inject all:replacements.If the user passed values such as
{ "firstName": "OR true; DROP TABLE users;", "lastName": ":firstName" }Sequelize would first generate this query:
Then would inject replacements in it, which resulted in this:
As you can see this resulted in arbitrary user-provided SQL being executed.
Patches
The issue was fixed in Sequelize 6.19.1
Workarounds
Do not use the
replacementsand thewhereoption in the same query if you are not using Sequelize >= 6.19.1References
See this thread for more information: https://github.com/sequelize/sequelize/issues/14519
Snyk: https://security.snyk.io/vuln/SNYK-JS-SEQUELIZE-2932027
CVE-2023-22580
Due to improper input filtering in the sequelize js library, can malicious queries lead to sensitive information disclosure.
CVE-2023-22579
Impact
Providing an invalid value to the
whereoption of a query caused Sequelize to ignore that option instead of throwing an error.A finder call like the following did not throw an error:
As this option is typically used with plain javascript objects, be aware that this only happens at the top level of this option.
Patches
This issue has been patched in
sequelize@6.28.1&@sequelize/core@7.0.0.alpha-20References
A discussion thread about this issue is open at https://github.com/sequelize/sequelize/discussions/15698
CVE: CVE-2023-22579
Snyk: https://security.snyk.io/vuln/SNYK-JS-SEQUELIZE-3324090
CVE-2023-22578
Impact
Sequelize 6.28.2 and prior has a dangerous feature where using parentheses in the attribute option would make Sequelize use the string as-is in the SQL
Produced
Patches
This feature was deprecated in Sequelize 5, and using it prints a deprecation warning.
This issue has been patched in
@sequelize/core@7.0.0.alpha-20andsequelize@6.29.0.In Sequelize 7, it now produces the following:
In Sequelize 6, it throws an error explaining that we had to introduce a breaking change, and requires the user to explicitly opt-in to either the Sequelize 7 behavior (always escape) or the Sequelize 5 behavior (inline attributes that include
()without escaping). See https://github.com/sequelize/sequelize/pull/15710 for more information.Mitigations
Do not use user-provided content to build your list or attributes. If you do, make sure that attribute in question actually exists on your model by checking that it exists in the
rawAttributesproperty of your model first.A discussion thread about this issue is open at https://github.com/sequelize/sequelize/discussions/15694
CVE: CVE-2023-22578
CVE-2026-30951
Summary
SQL injection via unescaped cast type in JSON/JSONB
whereclause processing. The_traverseJSON()function splits JSON path keys on::to extract a cast type, which is interpolated raw intoCAST(... AS <type>)SQL. An attacker who controls JSON object keys can inject arbitrary SQL and exfiltrate data from any table.Affected: v6.x through 6.37.7. v7 (
@sequelize/core) is not affected.Details
In
src/dialects/abstract/query-generator.js,_traverseJSON()extracts a cast type from::in JSON keys without validation:_castKey()(line 1925) passes it toUtils.Cast, andhandleSequelizeMethod()(line 1692) interpolates it directly:JSON path values are escaped via
this.escape()injsonPathExtractionQuery(), but the cast type is not.Suggested fix — whitelist known SQL data types:
PoC
npm install sequelize@6.37.7 sqlite3Output:
Impact
SQL Injection (CWE-89) — Any application that passes user-controlled objects as
whereclause values for JSON/JSONB columns is vulnerable. An attacker can exfiltrate data from any table in the database via UNION-based or boolean-blind injection. All dialects with JSON support are affected (SQLite, PostgreSQL, MySQL, MariaDB).A common vulnerable pattern:
Release Notes
sequelize/sequelize (sequelize)
v6.37.8Compare Source
Security improvements
v6.37.7Compare Source
Bug Fixes
v6.37.6Compare Source
Meta
v6.37.5Compare Source
Bug Fixes
v6.37.4Compare Source
Bug Fixes
v6.37.3Compare Source
Bug Fixes
v6.37.2Compare Source
Bug Fixes
readOnlyto the transaction options types and docs (#17226) (7c8972f)v6.37.1Compare Source
Bug Fixes
returninginSaveOptions. (#16954) (505467b)v6.37.0Compare Source
Features
v6.36.0Compare Source
Features
v6.35.2Compare Source
Bug Fixes
v6.35.1Compare Source
Bug Fixes
v6.35.0Compare Source
Features
findModelto v6 (#16705) (5bfbb99)v6.34.0Compare Source
Bug Fixes
Features
v6.33.0Compare Source
Bug Fixes
Features
v6.32.1Compare Source
Bug Fixes
v6.32.0Compare Source
Bug Fixes
typescondition to the front (#16085) (99c3530)Features
v6.31.1Compare Source
Bug Fixes
v6.31.0Compare Source
Bug Fixes
Features
v6.30.0Compare Source
Bug Fixes
Features
v6.29.3Compare Source
Bug Fixes
v6.29.2Compare Source
Bug Fixes
v6.29.1Compare Source
Bug Fixes
v6.29.0Compare Source
Features
v6.28.2Compare Source
Bug Fixes
v6.28.1Compare Source
Bug Fixes
v6.28.0Compare Source
Features
v6.27.0Compare Source
Features
v6.26.0Compare Source
Features
v6.25.8Compare Source
Bug Fixes
v6.25.7Compare Source
Bug Fixes
v6.25.6Compare Source
Bug Fixes
v6.25.5Compare Source
Bug Fixes
v6.25.4Compare Source
Bug Fixes
v6.25.3Compare Source
Bug Fixes
v6.25.2Compare Source
Bug Fixes
InferAttributes(v6) (#15135) (851daaf)v6.25.1Compare Source
Bug Fixes
v6.25.0Compare Source
Features
dialectOptions.connectString(#15042) (06ad05d)v6.24.0Compare Source
Features
QueryGenerator#tableExistsQuery(#15087) (a44772e)v6.23.2Compare Source
Bug Fixes
v6.23.1Compare Source
Bug Fixes
v6.23.0Compare Source
Features
v6.22.1Compare Source
Bug Fixes
v6.22.0Compare Source
Features
v6.21.6Compare Source
Bug Fixes
v6.21.5Compare Source
Bug Fixes
v6.21.4Compare Source
Bug Fixes
v6.21.3Compare Source
Bug Fixes
v6.21.2Compare Source
Bug Fixes
$infnargs (#14678) (7bb60e3)v6.21.1Compare Source
Bug Fixes
v6.21.0Compare Source
Features
v6.20.1Compare Source
Bug Fixes
v6.20.0Compare Source
Features
v6.19.2Compare Source
Bug Fixes
ARRAY[]& followed by;(#14518) (e37c572)v6.19.1Compare Source
Bug Fixes
:replacementsinside of strings (#14472) (ccaa399)v6.19.0Compare Source
Bug Fixes
WhereOptionsmore accurate (#14368) (0d0aade)Features
Model.initaware of pre-configured foreign keys (#14370) (5954d2c)v6.18.0Compare Source
Features
v6.17.0Compare Source
Bug Fixes
GroupedCountResultIteminterface (#14154) (a81b7ab)Model.update(#14155) (b80aeed)Features
Model.getAttributesstricter (#14017) (e974e20)v6.16.3Compare Source
Bug Fixes
v6.16.2Compare Source
Bug Fixes
v6.16.1Compare Source
Bug Fixes
package.jsonin Sequelize.version (#14073) (b95c213)v6.16.0Compare Source
Features
v6.15.1Compare Source
Bug Fixes
$nested.syntax$in WhereAttributeHash (#13983) (4a513cf)Sequelize.where(#14018) (99c612b)v6.15.0Compare Source
Bug Fixes
Features
Sequelize#querymethod (#13881) (7c58851)v6.14.1Compare Source
Bug Fixes
v6.14.0Compare Source
Bug Fixes
countandfindAndCountAll(#13786) (b06c1fc)Features
InferAttributesutility type (#13909) (fd42687)v6.13.0Compare Source
Bug Fixes
Features
v6.12.5Compare Source
Bug Fixes
v6.12.4Compare Source
Bug Fixes
v6.12.3Compare Source
Bug Fixes
v6.12.2Compare Source
Bug Fixes
v6.12.1Compare Source
Bug Fixes
v6.12.0Compare Source
Bug Fixes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.