Open
Conversation
shichongrui
reviewed
Jun 16, 2018
| // TODO: have to force "production" env or the react-reconciler will | ||
| // swallow errors in non-browser environments | ||
|
|
||
| if (process.env.NODE_ENV !== 'production') { |
There was a problem hiding this comment.
Can there be another flag other than just if it's not in production? Perhaps another variable such as INSPECT or something along those lines?
Contributor
Author
There was a problem hiding this comment.
I guess the question is, do we want to ship the extra libraries it requires on a production bundle too? React DOM is always enabled despite it being a production bundle or not. If that's the case, how about DEBUG then it can be shared with the debug module?
Owner
|
Wow, it looks amazing and I would like to take a try firstly. I think this feature may help to improve the development experience a lot. |
Contributor
Author
|
Good stuff, will wait for that then @oyyd! |
|
Have a merge conflict now. |
* master: doc: tips for node versions Fix text and entry not getting yoga styles chore: link to react-yue-app as an example of another app setup Move font and color definitions into style Update to latest react-reconciler api
Contributor
Author
|
fixed @shichongrui! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds some basic react-devtools integration:
Thanks to @nitin42 for https://github.com/nitin42/Making-a-custom-React-renderer/blob/c6e7dea06b4ab3527c5375f8e0a45c235304e56c/part-one.md and to @iamdustan for http://iamdustan.com/2016/02/19/react-devtools-renderer-integration/!