fix: demote resolved source commit blockers#459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #458.
Summary
source_commit_missingcurrent-blocker/outbox reflections once canonical promotion readiness proves provenance is complete.ready_for_policy_review) instead of continuing to headline the resolved provenance blocker.Test plan
test_api_demotes_stale_source_commit_blocker_when_promotion_provenance_is_completefailed because/api/system.control_plane.current_blocker.failure_classstayedsource_commit_missing.PYTHONPATH=ops/dashboard/src:ops/dashboard python3 -m pytest ops/dashboard/tests/test_dashboard_truth_audit_gaps.py::test_api_demotes_stale_source_commit_blocker_when_promotion_provenance_is_complete -q→ 1 passed.PYTHONPATH=ops/dashboard/src:ops/dashboard python3 -m pytest ops/dashboard/tests/test_dashboard_truth_audit_gaps.py -q→ 68 passed.PYTHONPATH=ops/dashboard/src:ops/dashboard python3 -m pytest ops/dashboard/tests/test_dashboard_truth_audit_gaps.py ops/dashboard/tests/test_autonomy_stagnation_dashboard.py ops/dashboard/tests/test_app.py -q→ 115 passed.PYTHONPATH=ops/dashboard/src:ops/dashboard python3 -m pytest ops/dashboard/tests -q→ 165 passed.python3 -m pytest tests -q→ 696 passed, 5 skipped.Live follow-up after merge
/collectand verify/api/mission-control.headlineno longer containssource_commit_missingwhen readiness hasprovenance_complete=trueandmissing_inputs=[].