fix: suppress stale blockers for healthy mission control#466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #465.
After #461/#463,
/api/systemand/api/analyticsreported canonical healthy autonomy:autonomy_verdict.state=healthy_progressautonomy_verdict.reasons=[]autonomy_verdict.blocking_summary=nullBut Mission Control still rendered a
Blocked:headline from a stalecurrent_blockerstring.This change makes
_mission_control_summary()defer to the canonical healthy autonomy verdict: when autonomy ishealthy_progresswith no reasons and no blocking summary, stale current-blocker text is suppressed for the top-level headline/current blocker state.Test plan
RED before fix:
PYTHONPATH=ops/dashboard/src:ops/dashboard python3 -m pytest ops/dashboard/tests/test_app.py::test_mission_control_healthy_autonomy_ignores_stale_current_blocker -qBlocked: active synthesized-improvement review lane remains bounded while awaiting materialization pressureGREEN after fix:
PYTHONPATH=ops/dashboard/src:ops/dashboard python3 -m pytest ops/dashboard/tests/test_app.py::test_mission_control_healthy_autonomy_ignores_stale_current_blocker ops/dashboard/tests/test_app.py::test_mission_control_names_concrete_blocker_from_autonomy_summary_when_current_blocker_unknown -q2 passedPYTHONPATH=ops/dashboard/src:ops/dashboard python3 -m pytest ops/dashboard/tests -q167 passedpython3 -m pytest tests -q699 passed, 5 skipped