fix(parallel): inherit plugin state from parent to support local WithSync - #6
Open
nepridumalnik wants to merge 1 commit into
Open
fix(parallel): inherit plugin state from parent to support local WithSync#6nepridumalnik wants to merge 1 commit into
nepridumalnik wants to merge 1 commit into
Conversation
|
I have applied your fixes and in case like this where scope is package examples_test
import (
"testing"
"time"
"github.com/ozontech/testo"
"github.com/ozontech/testo-toppings/parallel"
)
type T struct {
*testo.T
*parallel.PluginParallel
}
var _ = testo.Options(parallel.WithScope(parallel.SuiteTests | parallel.Suites | parallel.Tests))
// 1 - sync
// 2 - sync
// 3 - async
func TestSuitelessSequential(t *testing.T) {
t.Run("1st", testo.Test(func(t T) {
t.Log("start TestSuitelessSequential 1st")
time.Sleep(100 * time.Millisecond)
t.Log("end TestSuitelessSequential 1st")
}, parallel.WithSync()))
t.Run("2nd", testo.Test(func(t T) {
t.Log("start TestSuitelessSequential 2nd")
time.Sleep(100 * time.Millisecond)
t.Log("end TestSuitelessSequential 2nd")
}, parallel.WithSync()))
t.Run("3rd", testo.Test(func(t T) {
t.Log("start TestSuitelessSequential 3rd")
time.Sleep(100 * time.Millisecond)
t.Log("end TestSuitelessSequential 3rd")
}))
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
What does this PR do?
This PR fixes an issue where the local test option
WithSync()was completely ignored and overwritten by global configuration/CLI flags.How was it fixed?
Plugin()method inparallel/plugin.goto properly inherit configuration from theparentplugin if it is present.testoframework architecture, allowing local test options to override global/suite-level configurations.AI Disclosure
The solution and PR description were prepared with the assistance of Google Gemini. AI was used to analyze the
parallel/plugin.gofile structure, debug the state-overwriting behavior in thePlugin()method, and format the final code changes according to the framework's architecture.