Skip to content

Warn for CYRILLIC, unknown #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thinkyhead wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Warn for CYRILLIC, unknown #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
086bd81
Suppress sprintf warning
thinkyhead Apr 19, 2025
8350497
dead variable
thinkyhead Apr 19, 2025
2496b32
Allow CYRILLIC to build
thinkyhead Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/MarlinSimulator/hardware/HD44780Device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,12 @@ HD44780Device::HD44780Device(pin_type rs, pin_type en, pin_type d4, pin_type d5,
active_rom = hd44780_a00_rom;
#elif DISPLAY_CHARSET_HD44780 == WESTERN
active_rom = hd44780_a02_rom;
#elif DISPLAY_CHARSET_HD44780 == CYRILLIC
active_rom = hd44780_a02_rom;
#warning "CYRILLIC HD44780 Character ROM not available. Falling back to WESTERN."
#else
#error Unavailable HD44780 Character ROM
active_rom = hd44780_a02_rom;
#warning "Unknown HD44780 Character ROM. Falling back to WESTERN."
#endif
}

Expand Down
5 changes: 5 additions & 0 deletions src/MarlinSimulator/marlin_arduino_impl/arduino.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,18 @@ uint16_t analogRead(pin_t adc_pin) {
return Gpio::get(digitalPinToAnalogIndex(adc_pin));
}

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"

char *dtostrf(double __val, signed char __width, unsigned char __prec, char *__s) {
char format_string[20];
snprintf(format_string, 20, "%%%d.%df", __width, __prec);
sprintf(__s, format_string, __val);
return __s;
}

#pragma GCC diagnostic pop

int32_t random(int32_t max) {
return rand() % max;
}
Expand Down
1 change: 0 additions & 1 deletion src/MarlinSimulator/visualisation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ class Visualisation {
std::shared_ptr<renderer::ShaderProgram> default_program;

bool mouse_captured = false;
bool input_state[6] = {};
glm::vec<2, int> mouse_lock_pos;

#define BED_NORMAL 0.0, 1.0, 0.0
Expand Down