Skip to content

[bazel] Modify includes for piserver#648

Merged
fruffy merged 1 commit into
p4lang:mainfrom
c8ef:piserver-bazel
May 22, 2026
Merged

[bazel] Modify includes for piserver#648
fruffy merged 1 commit into
p4lang:mainfrom
c8ef:piserver-bazel

Conversation

@c8ef

@c8ef c8ef commented May 17, 2026

Copy link
Copy Markdown
Contributor

BMv2 has following use case:

https://github.com/p4lang/behavioral-model/blob/044fccf9d40b04849f9f0d9b314f63678738ec25/targets/simple_switch_grpc/switch_runner.cpp#L31

We need this patch to expose the piserver's header files so that BMv2 can successfully build with Bazel without missing header/include errors.

Signed-off-by: c8ef <c8ef@outlook.com>
@github-actions github-actions Bot added the bazel label May 17, 2026
@c8ef

c8ef commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

cc @fruffy @jafingerhut @matthewtlam for review.

@c8ef

c8ef commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

Also, from this bazel build run, we can see that the build cache is working well. The bazel action finished almost instantly.

@c8ef

c8ef commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Gentle ping on this PR since it's a required dependency for the bmv2 bazel build~

@jafingerhut

Copy link
Copy Markdown
Contributor

Gentle ping on this PR since it's a required dependency for the bmv2 bazel build~

FYI, I could rubber-stamp approve it, without knowing what the changes mean, as I have no knowledge of how Bazel works, but it would be better if someone with at least some knowledge of Bazel can review it.

@fruffy

fruffy commented May 19, 2026

Copy link
Copy Markdown
Contributor

Bazel changes should be reviewed by @p4lang/google-p4-infra folks.

@matthewtlam matthewtlam left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c8ef Can we update the PR description regarding that we need this to expose the piserver's header files so that BMv2 can successfully build with Bazel without missing header/include errors?

@c8ef

c8ef commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

Can we update the PR description regarding that we need this to expose the piserver's header files so that BMv2 can successfully build with Bazel without missing header/include errors?

Done.

@fruffy fruffy merged commit 0aa6c69 into p4lang:main May 22, 2026
7 checks passed
@c8ef c8ef deleted the piserver-bazel branch May 23, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants