Add bazel build system support for simple_switch_grpc#1401
Conversation
Signed-off-by: c8ef <c8ef@outlook.com>
Signed-off-by: c8ef <c8ef@outlook.com>
Signed-off-by: c8ef <c8ef@outlook.com>
Signed-off-by: c8ef <c8ef@outlook.com>
|
cc @matthewtlam @qobilidop for review. |
|
|
||
| load("@rules_cc//cc:cc_test.bzl", "cc_test") | ||
|
|
||
| _COMMON_SRCS = [ |
There was a problem hiding this comment.
Is there a particular reason why these are not apart of the _COMMON_DEPS?
There was a problem hiding this comment.
_COMMON_SRCS is a list of source files, whereas _COMMON_DEPS is a list of local or remote dependencies.
There was a problem hiding this comment.
Is it possible to make all the common source files be built similarly to the common deps? So that the only source files are the tests itself?
There was a problem hiding this comment.
I moved the common sources into a test_common library, so they can now be treated as common deps. However, the tests still need to run exclusively due to port sharing.
Signed-off-by: c8ef <c8ef@outlook.com>
This reverts commit f4bc3c7. Signed-off-by: c8ef <c8ef@outlook.com>
Signed-off-by: c8ef <c8ef@outlook.com>
Signed-off-by: c8ef <c8ef@outlook.com>
All resolved, please take another look. |
matthewtlam
left a comment
matthewtlam
left a comment
There was a problem hiding this comment.
Just looking for clarification on a couple of last comments but we are almost there!
Signed-off-by: c8ef <c8ef@outlook.com>
Thanks for the detailed review! I took the initiative to mark some addressed comments as resolved, but feel free to reopen them if you have further feedback. |
Signed-off-by: c8ef <c8ef@outlook.com>
matthewtlam
left a comment
matthewtlam
left a comment
There was a problem hiding this comment.
The refactoring in targets/simple_switch_grpc/tests/BUILD.bazel looks amazing and very explicit following Bazel standards. LGTM!
jafingerhut
left a comment
jafingerhut
left a comment
There was a problem hiding this comment.
Approving and merging based upon matthewtlam's review and approval.
3 participants
Uh oh!
There was an error while loading. Please reload this page.